From: Ana Rey <anarey@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: Ana Rey <anarey@gmail.com>
Subject: [libnftnl PATCH 4/4] expr: ct: Do not print unset values in json
Date: Tue, 24 Jun 2014 08:46:41 +0200 [thread overview]
Message-ID: <1403592401-5057-6-git-send-email-anarey@gmail.com> (raw)
In-Reply-To: <1403592401-5057-1-git-send-email-anarey@gmail.com>
It changes the parse functions to omit unset values.
Signed-off-by: Ana Rey <anarey@gmail.com>
---
src/expr/ct.c | 44 ++++++++++++++++++--------------------------
1 file changed, 18 insertions(+), 26 deletions(-)
diff --git a/src/expr/ct.c b/src/expr/ct.c
index f2718f9..28ac13b 100644
--- a/src/expr/ct.c
+++ b/src/expr/ct.c
@@ -231,44 +231,36 @@ static int nft_rule_expr_ct_json_parse(struct nft_rule_expr *e, json_t *root,
int key;
if (nft_jansson_node_exist(root, "dreg")) {
- if (nft_jansson_parse_reg(root, "dreg", NFT_TYPE_U32, ®, err) < 0)
- return -1;
-
- nft_rule_expr_set_u32(e, NFT_EXPR_CT_DREG, reg);
+ if (nft_jansson_parse_reg(root, "dreg", NFT_TYPE_U32, ®,
+ err) == 0)
+ nft_rule_expr_set_u32(e, NFT_EXPR_CT_DREG, reg);
}
if (nft_jansson_node_exist(root, "sreg")) {
- if (nft_jansson_parse_reg(root, "sreg", NFT_TYPE_U32, ®, err) < 0)
- return -1;
-
- nft_rule_expr_set_u32(e, NFT_EXPR_CT_SREG, reg);
+ if (nft_jansson_parse_reg(root, "sreg", NFT_TYPE_U32, ®,
+ err) == 0)
+ nft_rule_expr_set_u32(e, NFT_EXPR_CT_SREG, reg);
}
if (nft_jansson_node_exist(root, "key")) {
key_str = nft_jansson_parse_str(root, "key", err);
- if (key_str == NULL)
- return -1;
-
- key = str2ctkey(key_str);
- if (key < 0)
- goto err;
-
- nft_rule_expr_set_u32(e, NFT_EXPR_CT_KEY, key);
-
+ if (key_str != NULL) {
+ key = str2ctkey(key_str);
+ if (key >= 0)
+ nft_rule_expr_set_u32(e, NFT_EXPR_CT_KEY, key);
+ }
}
if (nft_jansson_node_exist(root, "dir")) {
dir_str = nft_jansson_parse_str(root, "dir", err);
- if (dir_str == NULL)
- return -1;
-
- if (str2ctdir(dir_str, &dir) != 0) {
- err->node_name = "dir";
- err->error = NFT_PARSE_EBADTYPE;
- goto err;
- }
-
+ if (dir_str != NULL) {
+ if (str2ctdir(dir_str, &dir) != 0) {
+ err->node_name = "dir";
+ err->error = NFT_PARSE_EBADTYPE;
+ goto err;
+ }
nft_rule_expr_set_u8(e, NFT_EXPR_CT_DIR, dir);
+ }
}
return 0;
--
2.0.0
prev parent reply other threads:[~2014-06-24 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 6:46 [libnftnl PATCH 0/4] expr: ct: Do not print unset values in xml and json Ana Rey
2014-06-24 6:46 ` [libnftnl PATCH 1/4] expr: ct: Use nft_rule_expr_set_* in the xml parsing code Ana Rey
2014-06-24 6:46 ` [libnftnl PATCH 2/4] expr: ct: Do not print unset values in xml file Ana Rey
2014-06-24 6:46 ` [libnftnl PATCH 3/4] expr: ct: Delete the last comma character in json text Ana Rey
2014-06-24 6:46 ` [libnftnl PATCH 4/4] expr: ct: Do not print unset values in json Ana Rey
2014-06-24 6:46 ` Ana Rey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403592401-5057-6-git-send-email-anarey@gmail.com \
--to=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).