netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alvaro Neira Ayuso <alvaroneay@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net
Subject: [nft PATCH 0/4] Changes in nft byteorder conversions
Date: Mon, 28 Jul 2014 13:51:47 +0200	[thread overview]
Message-ID: <1406548311-31354-1-git-send-email-alvaroneay@gmail.com> (raw)

Currently, when we have added a rule, we have done some byteorder conversions
in the parser step, evaluation step and linealize step. For that, in some case
if we try to add rules, we have done wrong byteorder conversions and we have had
matching problems or when we have tried to show the rules that we have added
we have showed rules with values in wrong byteorder. We have had too this
problems when we have used sets or range.

This series of patches changes the policy for doing byteorder conversions in our
rules. We are going to do all the conversions in two steps, parser and
evaluation. That changes remove consecutive byteorder conversions, make more
easy administrate the byteorder conversions for adding and for showing rules and
fix some case that we don't update correctly the context for using values
without correctly byteorder conversions. This patches enables to use ranges and
sets with the rules without problems.

Comments are welcome.

Alvaro Neira Ayuso (4):
  payload: fix update context with wrong byteorder
  src: fix byteorder conversions in simple values
  src: fix byteorder conversions in range values
  src: fix byteorder conversions in sets

 include/gmputil.h         |    1 +
 include/netlink.h         |    3 +--
 src/datatype.c            |    8 ++++++--
 src/evaluate.c            |   48 +++++++++++++++++++++++++++++---------------
 src/expression.c          |    8 ++++++--
 src/gmputil.c             |   15 +++++++++++++-
 src/netlink.c             |   13 ++++++++----
 src/netlink_delinearize.c |   49 +++++++++++++++++++++++++++++++++++++++++----
 src/netlink_linearize.c   |   10 ++++-----
 src/payload.c             |   10 ++++++---
 10 files changed, 126 insertions(+), 39 deletions(-)

-- 
1.7.10.4


             reply	other threads:[~2014-07-28 11:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28 11:51 Alvaro Neira Ayuso [this message]
2014-07-28 11:51 ` [nft PATCH 1/4] payload: fix update context with wrong byteorder Alvaro Neira Ayuso
2014-07-28 11:51 ` [nft PATCH 2/4 v2] src: fix byteorder conversions in simple values Alvaro Neira Ayuso
2014-07-28 11:51 ` [nft PATCH 3/4] src: fix byteorder conversions in range values Alvaro Neira Ayuso
2014-07-28 11:51 ` [nft PATCH 4/4] src: fix byteorder conversions in sets Alvaro Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406548311-31354-1-git-send-email-alvaroneay@gmail.com \
    --to=alvaroneay@gmail.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).