netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alvaro Neira Ayuso <alvaroneay@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net
Subject: [nft PATCH 0/5] Changes in nft byteorder conversions
Date: Mon,  4 Aug 2014 18:00:06 +0200	[thread overview]
Message-ID: <1407168011-6424-1-git-send-email-alvaroneay@gmail.com> (raw)

Currently, if we add a rule, we do some byteorder conversions in the parser,
evaluation and linealize steps. So, if we try to add rules, we do wrong
byteorder conversions. Therefore, we have matching problems or we show
the rules with wrong byteorder. Usually, we have these problems with sets
and ranges.

These series of patches changes the policy for doing byteorder conversions in our
rules. We are going to do all the conversions in two steps, parser and
evaluation. That changes remove consecutive byteorder conversions. Thus, these
patches fixing these problems for adding and for showing rules. Too, fix some
case that we don't update correctly the context for using values without
correctly byteorder conversions. These patches enables to use ranges and sets
with the rules without problems.

Comments are welcome.

Alvaro Neira Ayuso (5):
  payload: fix update context with wrong byteorder
  payload: generate dependency in the correct byteorder
  src: fix byteorder conversions in constant values
  src: fix byteorder conversions in range values
  src: fix byteorder conversions in sets

 include/datatype.h        |    1 +
 include/expression.h      |    2 ++
 include/netlink.h         |    3 +--
 src/datatype.c            |   16 +++++++++++++--
 src/evaluate.c            |   37 ++++++++++++++++++++++++++++-------
 src/expression.c          |   17 ++++++++++++++--
 src/gmputil.c             |    9 +++++++--
 src/netlink.c             |   13 +++++++++----
 src/netlink_delinearize.c |   47 +++++++++++++++++++++++++++++++++++++++++----
 src/netlink_linearize.c   |   10 +++++-----
 src/payload.c             |   10 +++++++---
 src/proto.c               |    2 +-
 12 files changed, 135 insertions(+), 32 deletions(-)

-- 
1.7.10.4


             reply	other threads:[~2014-08-04 16:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04 16:00 Alvaro Neira Ayuso [this message]
2014-08-04 16:00 ` [nft PATCH 1/5] payload: fix update context with wrong byteorder Alvaro Neira Ayuso
2014-08-16 14:17   ` Patrick McHardy
2014-08-04 16:00 ` [nft PATCH 2/5] payload: generate dependency in the correct byteorder Alvaro Neira Ayuso
2014-08-16 14:19   ` Patrick McHardy
2014-08-04 16:00 ` [nft PATCH 3/5 v3] src: fix byteorder conversions in constant values Alvaro Neira Ayuso
2014-08-16 14:45   ` Patrick McHardy
2014-08-04 16:00 ` [nft PATCH 4/5 v2] src: fix byteorder conversions in range values Alvaro Neira Ayuso
2014-08-04 16:00 ` [nft PATCH 5/5 v2] src: fix byteorder conversions in sets Alvaro Neira Ayuso
2014-08-04 16:15   ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407168011-6424-1-git-send-email-alvaroneay@gmail.com \
    --to=alvaroneay@gmail.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).