From: Alvaro Neira Ayuso <alvaroneay@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net
Subject: [nft PATCH 2/5] payload: generate dependency in the correct byteorder
Date: Mon, 4 Aug 2014 18:00:08 +0200 [thread overview]
Message-ID: <1407168011-6424-3-git-send-email-alvaroneay@gmail.com> (raw)
In-Reply-To: <1407168011-6424-1-git-send-email-alvaroneay@gmail.com>
Currently, we suppose that all the dependency are in host endian. The problem
is if we try to add a dependency with big endian byteorder, we create
this dependency wrong. For example, if we add a ether type dependency in bridge,
we must use big endian byteorder and we use host endian and we create wrong the
payload.
Now, we are going to create the dependency taking account the byteorder.
Signed-off-by: Alvaro Neira Ayuso <alvaroneay@gmail.com>
---
src/payload.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/payload.c b/src/payload.c
index be3d610..8b10a79 100644
--- a/src/payload.c
+++ b/src/payload.c
@@ -213,8 +213,7 @@ int payload_gen_dependency(struct eval_ctx *ctx, const struct expr *expr,
left = payload_expr_alloc(&expr->location, desc, desc->protocol_key);
right = constant_expr_alloc(&expr->location, tmpl->dtype,
- BYTEORDER_HOST_ENDIAN,
- tmpl->len,
+ tmpl->dtype->byteorder, tmpl->len,
constant_data_ptr(protocol, tmpl->len));
dep = relational_expr_alloc(&expr->location, OP_EQ, left, right);
--
1.7.10.4
next prev parent reply other threads:[~2014-08-04 16:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 16:00 [nft PATCH 0/5] Changes in nft byteorder conversions Alvaro Neira Ayuso
2014-08-04 16:00 ` [nft PATCH 1/5] payload: fix update context with wrong byteorder Alvaro Neira Ayuso
2014-08-16 14:17 ` Patrick McHardy
2014-08-04 16:00 ` Alvaro Neira Ayuso [this message]
2014-08-16 14:19 ` [nft PATCH 2/5] payload: generate dependency in the correct byteorder Patrick McHardy
2014-08-04 16:00 ` [nft PATCH 3/5 v3] src: fix byteorder conversions in constant values Alvaro Neira Ayuso
2014-08-16 14:45 ` Patrick McHardy
2014-08-04 16:00 ` [nft PATCH 4/5 v2] src: fix byteorder conversions in range values Alvaro Neira Ayuso
2014-08-04 16:00 ` [nft PATCH 5/5 v2] src: fix byteorder conversions in sets Alvaro Neira Ayuso
2014-08-04 16:15 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407168011-6424-3-git-send-email-alvaroneay@gmail.com \
--to=alvaroneay@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).