netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yuxuan Shui <yshuiv7@gmail.com>
To: pablo@netfilter.org
Cc: tomasz.bursztyka@linux.intel.com,
	netfilter-devel@vger.kernel.org, Yuxuan Shui <yshuiv7@gmail.com>
Subject: [PATCH nftables] payload: use proto_unknown for raw protocol header
Date: Sat,  9 Aug 2014 21:01:17 +0800	[thread overview]
Message-ID: <1407589277-15812-1-git-send-email-yshuiv7@gmail.com> (raw)

Otherwise payload.desc would be NULL, which causes the crash in bug 915.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
---
 src/payload.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/payload.c b/src/payload.c
index a1785a5..842b1ea 100644
--- a/src/payload.c
+++ b/src/payload.c
@@ -106,6 +106,7 @@ struct expr *payload_expr_alloc(const struct location *loc,
 	} else {
 		tmpl = &proto_unknown_template;
 		base = PROTO_BASE_INVALID;
+		desc = &proto_unknown;
 	}
 
 	expr = expr_alloc(loc, &payload_expr_ops, tmpl->dtype,
-- 
2.0.4


             reply	other threads:[~2014-08-09 13:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-09 13:01 Yuxuan Shui [this message]
2014-08-20 13:19 ` [PATCH nftables] payload: use proto_unknown for raw protocol header Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407589277-15812-1-git-send-email-yshuiv7@gmail.com \
    --to=yshuiv7@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=tomasz.bursztyka@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).