netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alvaro Neira Ayuso <alvaroneay@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net
Subject: [nft PATCH 4/4 v3] evaluate: fix a crash if we check the transport protocol is tcp
Date: Tue, 21 Oct 2014 01:29:40 +0200	[thread overview]
Message-ID: <1413847780-10149-4-git-send-email-alvaroneay@gmail.com> (raw)
In-Reply-To: <1413847780-10149-1-git-send-email-alvaroneay@gmail.com>

Example:

nft add rule inet filter input meta l4proto udp reject with tcp reset

If we try to check if the transport protocol is tcp, we use the network context.
If we don't have this network context, we have a crash.

Signed-off-by: Alvaro Neira Ayuso <alvaroneay@gmail.com>
---
[changes in v3]
 * Use the proto_inet_service proto in cases that we don't have network context

 src/evaluate.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/evaluate.c b/src/evaluate.c
index 8b19baf..fc3b1a2 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -1365,6 +1365,12 @@ static int stmt_evaluate_reset(struct eval_ctx *ctx, struct stmt *stmt)
 	if (desc == NULL)
 		return 0;
 
+	/* If we don't have network context in inet or bridge */
+	if (base == NULL &&
+	    (ctx->pctx.family == NFPROTO_INET ||
+	     ctx->pctx.family == NFPROTO_BRIDGE))
+		base = &proto_inet_service;
+
 	protonum = proto_find_num(base, desc);
 	switch (protonum) {
 	case IPPROTO_TCP:
-- 
1.7.10.4


  parent reply	other threads:[~2014-10-20 23:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20 23:29 [nft PATCH 1/4] evaluate: refactor function to check the reject family in inet and bridge Alvaro Neira Ayuso
2014-10-20 23:29 ` [nft PATCH 2/4] evaluate: accept a reject reason with incorrect network context Alvaro Neira Ayuso
2014-10-20 23:29 ` [nft PATCH 3/4] evaluate: no check the network context in reject with tcp reset reason Alvaro Neira Ayuso
2014-10-21  7:55   ` Pablo Neira Ayuso
2014-10-21 12:32     ` Álvaro Neira Ayuso
2014-10-20 23:29 ` Alvaro Neira Ayuso [this message]
2014-10-21  8:15   ` [nft PATCH 4/4 v3] evaluate: fix a crash if we check the transport protocol is tcp Pablo Neira Ayuso
2014-10-21 12:28     ` Álvaro Neira Ayuso
2014-10-21  8:45 ` [nft PATCH 1/4] evaluate: refactor function to check the reject family in inet and bridge Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413847780-10149-4-git-send-email-alvaroneay@gmail.com \
    --to=alvaroneay@gmail.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).