netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH 0/3] netfilter: nf_log: nlmsg size fixes
Date: Thu, 23 Oct 2014 10:36:05 +0200	[thread overview]
Message-ID: <1414053368-29037-1-git-send-email-fw@strlen.de> (raw)

The following three patches attempt to cure the reported
nlmsg skb trailroom exhaustion bug.

First two patches add missing size accounting, third patch
relaxes the impact of out-of-tailroom by tossing the skb
and giving a WARN_ONCE trace with size information, so we can
investigate further if needed.

Florian Westphal (2):
      netfilter: nf_log: account for size of NLMSG_DONE attribute in skb size
      netfilter: nfnetlink_log: fix maximum packet length logged to userspace

Houcheng Lin (1):
      netfilter: nf_log: release skbuff on nlmsg put failure

 net/netfilter/nfnetlink_log.c | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

             reply	other threads:[~2014-10-23  8:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-23  8:36 Florian Westphal [this message]
2014-10-23  8:36 ` [PATCH 1/3] netfilter: nf_log: account for size of NLMSG_DONE attribute Florian Westphal
2014-10-24 12:30   ` Pablo Neira Ayuso
2014-10-24 12:39     ` Pablo Neira Ayuso
2014-10-23  8:36 ` [PATCH 2/3] netfilter: nfnetlink_log: fix maximum packet length logged to userspace Florian Westphal
2014-10-24 12:33   ` Pablo Neira Ayuso
2014-10-23  8:36 ` [PATCH 3/3] netfilter: nf_log: release skbuff on nlmsg put failure Florian Westphal
2014-10-24 12:35   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414053368-29037-1-git-send-email-fw@strlen.de \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).