From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net, fw@strlen.de, stephen@networkplumber.org
Subject: [PATCH 0/5] bridge reject fixes
Date: Tue, 28 Oct 2014 14:38:49 +0100 [thread overview]
Message-ID: <1414503534-10324-1-git-send-email-pablo@netfilter.org> (raw)
Hi,
I made an early design mistake by adding support for bridge reject that
relies on the IP stack, that was not a good idea. So this patchset
amends the situation by:
1) Refactoring common code that can be reused to forge the reject packets
now available at nf_reject_ipv4 and nf_reject_ipv6 from the bridge stack.
2) Forge the reject packets (TCP and ICMP dest unreach) that are injected
into the bridge stack using br_deliver() to the bridge port origin.
So the idea is to avoid any interaction with the IP stack, that has been
causing us problems specifically in the br_netfilter code. This also
aims to provide a native replacement to the use of iptables ... -j REJECT
from br_netfilter.
Note that I have restricted the reject expression to bridge prerouting and
input. Otherwise, I think we may send several reject reject packets when
there is no destination yet in the bridge fdb.
Comments welcome. Thanks.
Pablo Neira Ayuso (5):
netfilter: nf_tables_bridge: update hook_mask to allow {pre,post}routing
netfilter: nf_reject_ipv4: split nf_send_reset() in smaller functions
netfilter: nf_reject_ipv6: split nf_send_reset6() in smaller functions
netfilter: nft_reject_bridge: don't use IP stack to reject traffic
netfilter: nft_reject_bridge: restrict reject to prerouting and input
include/net/netfilter/ipv4/nf_reject.h | 10 +
include/net/netfilter/ipv6/nf_reject.h | 10 +
net/bridge/br_forward.c | 1 +
net/bridge/netfilter/nf_tables_bridge.c | 6 +-
net/bridge/netfilter/nft_reject_bridge.c | 296 ++++++++++++++++++++++++++++--
net/ipv4/netfilter/nf_reject_ipv4.c | 88 ++++++---
net/ipv6/netfilter/nf_reject_ipv6.c | 174 +++++++++++-------
7 files changed, 480 insertions(+), 105 deletions(-)
--
1.7.10.4
next reply other threads:[~2014-10-28 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 13:38 Pablo Neira Ayuso [this message]
2014-10-28 13:38 ` [PATCH 1/5] netfilter: nf_tables_bridge: update hook_mask to allow {pre,post}routing Pablo Neira Ayuso
2014-10-28 13:38 ` [PATCH 2/5] netfilter: nf_reject_ipv4: split nf_send_reset() in smaller functions Pablo Neira Ayuso
2014-10-28 13:38 ` [PATCH 3/5] netfilter: nf_reject_ipv6: split nf_send_reset6() " Pablo Neira Ayuso
2014-10-28 13:38 ` [PATCH 4/5] netfilter: nft_reject_bridge: don't use IP stack to reject traffic Pablo Neira Ayuso
2014-10-28 13:38 ` [PATCH 5/5] netfilter: nft_reject_bridge: restrict reject to prerouting and input Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414503534-10324-1-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).