netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alvaro Neira Ayuso <alvaroneay@gmail.com>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH nf 2/2] bridge: set the pktinfo for IPv4/IPv6 traffic
Date: Fri, 14 Nov 2014 11:29:50 +0100	[thread overview]
Message-ID: <1415960990-19489-2-git-send-email-alvaroneay@gmail.com> (raw)
In-Reply-To: <1415960990-19489-1-git-send-email-alvaroneay@gmail.com>

This patch sets the pktinfo for IPv4/IPv6 traffic. Therefore, we can check the
meta l4proto for IPv4/IPv6 traffic in bridge, before we don't have enough
information to do it.

Signed-off-by: Alvaro Neira Ayuso <alvaroneay@gmail.com>
---
 net/bridge/netfilter/nf_tables_bridge.c |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/net/bridge/netfilter/nf_tables_bridge.c b/net/bridge/netfilter/nf_tables_bridge.c
index d468c19..0a0f0ca 100644
--- a/net/bridge/netfilter/nf_tables_bridge.c
+++ b/net/bridge/netfilter/nf_tables_bridge.c
@@ -16,6 +16,8 @@
 #include <net/netfilter/nf_tables_bridge.h>
 #include <linux/ip.h>
 #include <linux/ipv6.h>
+#include <net/netfilter/nf_tables_ipv4.h>
+#include <net/netfilter/nf_tables_ipv6.h>
 
 int nft_bridge_iphdr_validate(struct sk_buff *skb)
 {
@@ -71,8 +73,21 @@ nft_do_chain_bridge(const struct nf_hook_ops *ops,
 {
 	struct nft_pktinfo pkt;
 
-	nft_set_pktinfo(&pkt, ops, skb, in, out);
+	switch (eth_hdr(skb)->h_proto) {
+	case htons(ETH_P_IP):
+		if (!nft_bridge_iphdr_validate(skb))
+			break;
+		nft_set_pktinfo_ipv4(&pkt, ops, skb, in, out);
+		return nft_do_chain(&pkt, ops);
+	case htons(ETH_P_IPV6):
+		if (!nft_bridge_ip6hdr_validate(skb))
+			break;
+		if (nft_set_pktinfo_ipv6(&pkt, ops, skb, in, out) < 0)
+			break;
+		return nft_do_chain(&pkt, ops);
+	}
 
+	nft_set_pktinfo(&pkt, ops, skb, in, out);
 	return nft_do_chain(&pkt, ops);
 }
 
-- 
1.7.10.4


  reply	other threads:[~2014-11-14 10:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14 10:29 [PATCH nf 1/2] bridge: export nft_reject_ip*hdr_validate functions Alvaro Neira Ayuso
2014-11-14 10:29 ` Alvaro Neira Ayuso [this message]
2014-11-20 13:06   ` [PATCH nf 2/2] bridge: set the pktinfo for IPv4/IPv6 traffic Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415960990-19489-2-git-send-email-alvaroneay@gmail.com \
    --to=alvaroneay@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).