From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: anarey@gmail.com
Subject: [nft-tests 1/2] tests: regression: don't use -nnn for non-list commands
Date: Sun, 23 Nov 2014 22:22:47 +0100 [thread overview]
Message-ID: <1416777768-1577-1-git-send-email-pablo@netfilter.org> (raw)
Not useful, they just bloat the nft-tests.py output.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
tests/regression/nft-test.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/regression/nft-test.py b/tests/regression/nft-test.py
index 00c33f3..e1aec89 100755
--- a/tests/regression/nft-test.py
+++ b/tests/regression/nft-test.py
@@ -305,7 +305,7 @@ def set_add_elements(set_element, set_name, set_all, state, table_list,
element = element + ", " + e
set_text = set_name + " { " + element + " }"
- cmd = "nft add element -nnn" + table_info + set_text
+ cmd = "nft add element" + table_info + set_text
ret = execute_cmd(cmd, filename, lineno)
if (state == "fail" and ret == 0) or (state == "ok" and ret != 0):
@@ -331,7 +331,7 @@ def set_delete_elements(set_element, set_name, table, filename=None,
for element in set_element:
set_text = set_name + " {" + element + "}"
- cmd = "nft delete element -nnn" + table_info + set_text
+ cmd = "nft delete element" + table_info + set_text
ret = execute_cmd(cmd, filename, lineno)
if ret != 0:
reason = "I cannot delete an element" + element + \
@@ -447,7 +447,7 @@ def rule_add(rule, table_list, chain_list, filename, lineno,
unit_tests += 1
table_flush(table, filename, lineno)
table_info = " " + table[0] + " " + table[1] + " "
- cmd = "nft add rule -nnn" + table_info + chain + " " + rule[0]
+ cmd = "nft add rule" + table_info + chain + " " + rule[0]
ret = execute_cmd(cmd, filename, lineno)
--
1.7.10.4
next reply other threads:[~2014-11-23 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 21:22 Pablo Neira Ayuso [this message]
2014-11-23 21:22 ` [nft-tests 2/2] tests: regression: any/meta.t: fix bogus error Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416777768-1577-1-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).