From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: [PATCH] netfilter: Fix build for NETFILTER_XT_TARGET_REDIRECT Date: Sat, 6 Dec 2014 01:41:59 -0800 Message-ID: <1417858919-10576-1-git-send-email-linux@roeck-us.net> Cc: coreteam@netfilter.org, netdev@vger.kernel.org, Guenter Roeck , Pablo Neira Ayuso , Arturo Borrero Gonzalez To: netfilter-devel@vger.kernel.org Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:34919 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbaLFJmH (ORCPT ); Sat, 6 Dec 2014 04:42:07 -0500 Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1XxBsL-001pBg-Kt for netfilter-devel@vger.kernel.org; Sat, 06 Dec 2014 09:42:05 +0000 Sender: netfilter-devel-owner@vger.kernel.org List-ID: Fix: ERROR: "nf_nat_redirect_ipv6" [net/netfilter/xt_REDIRECT.ko] undefined! Seen if NETFILTER_XT_TARGET_REDIRECT is configured but NF_NAT_IPV6 is not, since code compiled with NF_NAT_REDIRECT_IPV6 is used unconditionally by code enabled with NETFILTER_XT_TARGET_REDIRECT. This means that NETFILTER_XT_TARGET_REDIRECT depends on NF_NAT_IPV6 and must always select NF_NAT_REDIRECT_IPV6. Cc: Pablo Neira Ayuso Cc: Arturo Borrero Gonzalez Signed-off-by: Guenter Roeck --- Seen in and applies to -next. See various qemu test failures reported at http://server.roeck-us.net:8010/builders, net/netfilter/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index 57f15a9..2134ef0 100644 --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -843,9 +843,9 @@ config NETFILTER_XT_TARGET_RATEEST config NETFILTER_XT_TARGET_REDIRECT tristate "REDIRECT target support" - depends on NF_NAT + depends on NF_NAT && NF_NAT_IPV6 select NF_NAT_REDIRECT_IPV4 if NF_NAT_IPV4 - select NF_NAT_REDIRECT_IPV6 if NF_NAT_IPV6 + select NF_NAT_REDIRECT_IPV6 ---help--- REDIRECT is a special case of NAT: all incoming connections are mapped onto the incoming interface's address, causing the packets to -- 1.9.1