From: Patrick McHardy <kaber@trash.net>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org
Subject: [PATCH 2/3] dtype: fix memory leak in concat_type_destroy()
Date: Thu, 11 Dec 2014 22:21:13 +0000 [thread overview]
Message-ID: <1418336474-25567-2-git-send-email-kaber@trash.net> (raw)
In-Reply-To: <1418336474-25567-1-git-send-email-kaber@trash.net>
Free allocated memory for ->desc.
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
src/datatype.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/datatype.c b/src/datatype.c
index db3fb06..5599c59 100644
--- a/src/datatype.c
+++ b/src/datatype.c
@@ -950,6 +950,8 @@ const struct datatype *concat_type_alloc(const struct expr *expr)
void concat_type_destroy(const struct datatype *dtype)
{
- if (dtype->flags & DTYPE_F_ALLOC)
+ if (dtype->flags & DTYPE_F_ALLOC) {
+ xfree(dtype->desc);
xfree(dtype);
+ }
}
--
2.1.0
next prev parent reply other threads:[~2014-12-11 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 22:21 [PATCH 1/3] meta: properly align types in meta_template table Patrick McHardy
2014-12-11 22:21 ` Patrick McHardy [this message]
2014-12-11 22:21 ` [PATCH 3/3] datatype: print datatype name in datatype_print() BUG message Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418336474-25567-2-git-send-email-kaber@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).