* [PATCH 1/1 net-next] netfilter: remove unnecessary sizeof(char)
@ 2014-12-22 18:36 Fabian Frederick
2014-12-23 13:33 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-12-22 18:36 UTC (permalink / raw)
To: linux-kernel
Cc: davem, joe, Fabian Frederick, Pablo Neira Ayuso, Patrick McHardy,
Jozsef Kadlecsik, netfilter-devel, coreteam, netdev
sizeof(char) is always 1.
Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
net/netfilter/nf_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nf_log.c b/net/netfilter/nf_log.c
index 43c926c..1191f66 100644
--- a/net/netfilter/nf_log.c
+++ b/net/netfilter/nf_log.c
@@ -426,7 +426,7 @@ static int netfilter_log_sysctl_init(struct net *net)
nf_log_sysctl_fnames[i];
nf_log_sysctl_table[i].data = NULL;
nf_log_sysctl_table[i].maxlen =
- NFLOGGER_NAME_LEN * sizeof(char);
+ NFLOGGER_NAME_LEN;
nf_log_sysctl_table[i].mode = 0644;
nf_log_sysctl_table[i].proc_handler =
nf_log_proc_dostring;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1 net-next] netfilter: remove unnecessary sizeof(char)
2014-12-22 18:36 [PATCH 1/1 net-next] netfilter: remove unnecessary sizeof(char) Fabian Frederick
@ 2014-12-23 13:33 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2014-12-23 13:33 UTC (permalink / raw)
To: Fabian Frederick
Cc: linux-kernel, davem, joe, Patrick McHardy, Jozsef Kadlecsik,
netfilter-devel, coreteam, netdev
On Mon, Dec 22, 2014 at 07:36:15PM +0100, Fabian Frederick wrote:
> sizeof(char) is always 1.
Applied, thanks.
Made a small change on it:
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> net/netfilter/nf_log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/nf_log.c b/net/netfilter/nf_log.c
> index 43c926c..1191f66 100644
> --- a/net/netfilter/nf_log.c
> +++ b/net/netfilter/nf_log.c
> @@ -426,7 +426,7 @@ static int netfilter_log_sysctl_init(struct net *net)
> nf_log_sysctl_fnames[i];
> nf_log_sysctl_table[i].data = NULL;
> nf_log_sysctl_table[i].maxlen =
> - NFLOGGER_NAME_LEN * sizeof(char);
> + NFLOGGER_NAME_LEN;
this now fits in one line (80-chars).
> nf_log_sysctl_table[i].mode = 0644;
> nf_log_sysctl_table[i].proc_handler =
> nf_log_proc_dostring;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-23 13:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-22 18:36 [PATCH 1/1 net-next] netfilter: remove unnecessary sizeof(char) Fabian Frederick
2014-12-23 13:33 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).