From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 3/3] x_tables: Factor out 16bit aligment ifname_compare() Date: Sun, 11 Jan 2015 13:14:13 -0800 Message-ID: <1421010853.9233.7.camel@perches.com> References: <1421009571-5279-1-git-send-email-richard@nod.at> <1421009571-5279-4-git-send-email-richard@nod.at> <1421009969.9233.5.camel@perches.com> <54B2E4DD.90200@nod.at> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, coreteam@netfilter.org, netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bhutchings@solarflare.com, john.fastabend@gmail.com, herbert@gondor.apana.org.au, vyasevic@redhat.com, jiri@resnulli.us, vfalico@gmail.com, therbert@google.com, edumazet@google.com, yoshfuji@linux-ipv6.org, jmorris@namei.org, kuznet@ms2.inr.ac.ru, kadlec@blackhole.kfki.hu, kaber@trash.net, pablo@netfilter.org, kay@vrfy.org, stephen@networkplumber.org To: Richard Weinberger Return-path: In-Reply-To: <54B2E4DD.90200@nod.at> Sender: linux-kernel-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Sun, 2015-01-11 at 22:02 +0100, Richard Weinberger wrote: > Am 11.01.2015 um 21:59 schrieb Joe Perches: > > On Sun, 2015-01-11 at 21:52 +0100, Richard Weinberger wrote: > >> arp_tables.c has a 16bit aligment ifname_compare(), factor > >> it out to use it for all tables. [] > > Perhaps this would be better as bool ifname_compare > Let's discuss the whole concept first The concept seems obvious enough