From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 3/3] x_tables: Factor out 16bit aligment ifname_compare() Date: Mon, 12 Jan 2015 00:40:51 -0800 Message-ID: <1421052051.9233.11.camel@perches.com> References: <54B2EB81.5050604@nod.at> <1421012376.9233.9.camel@perches.com> <54B2EE4D.2080802@nod.at> <20150111.215050.458358747958425038.davem@davemloft.net> <54B3834D.6090602@nod.at> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: David Miller , coreteam@netfilter.org, netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bhutchings@solarflare.com, john.fastabend@gmail.com, herbert@gondor.apana.org.au, vyasevic@redhat.com, jiri@resnulli.us, vfalico@gmail.com, therbert@google.com, edumazet@google.com, yoshfuji@linux-ipv6.org, jmorris@namei.org, kuznet@ms2.inr.ac.ru, kadlec@blackhole.kfki.hu, kaber@trash.net, pablo@netfilter.org, kay@vrfy.org, stephen@networkplumber.org To: Richard Weinberger Return-path: Received: from smtprelay0238.hostedemail.com ([216.40.44.238]:44334 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752299AbbALIk5 (ORCPT ); Mon, 12 Jan 2015 03:40:57 -0500 In-Reply-To: <54B3834D.6090602@nod.at> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Mon, 2015-01-12 at 09:18 +0100, Richard Weinberger wrote: > Am 12.01.2015 um 03:50 schrieb David Miller: > > From: Richard Weinberger > > Date: Sun, 11 Jan 2015 22:42:37 +0100 > > > >> Joe, I really don't care. This is the least significant > >> patch of the series. > >> I'll no longer waste my time with that. > > > > If you're not willing to fix stylistic issues now, then nobody should > > bother wasting their time on the high level issues of your patch. > > > > Just fix these things now rather than being difficult, this is a part > > of patch review that everyone has to do, not just you. > > I apologize, it was not my intention to be difficult. No worries. The unsigned long return is kind of odd with a compare_ name as those are generally, as Jan mentioned, signed comparison style return values. I'd probably use a different function name too bool ifname_equal(const char *a, const char *b, const char *mask) { } to try to make the return value more obvious too. > If you and netfilter folks now prefer bool > for such string compare functions I'll happily address this in > v2 of my series. Thanks