From: Alvaro Neira Ayuso <alvaroneay@gmail.com>
To: netfilter-devel@vger.kernel.org
Subject: [libnftnl PATCH] mxml: test if the root node name is initialized before to compare it.
Date: Mon, 2 Mar 2015 20:58:38 +0100 [thread overview]
Message-ID: <1425326318-22936-1-git-send-email-alvaroneay@gmail.com> (raw)
If the root node name is not correctly initialized, we have a crash.
Signed-off-by: Alvaro Neira Ayuso <alvaroneay@gmail.com>
---
src/mxml.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mxml.c b/src/mxml.c
index 0001ba0..b68f86f 100644
--- a/src/mxml.c
+++ b/src/mxml.c
@@ -43,7 +43,8 @@ mxml_node_t *nft_mxml_build_tree(const void *data, const char *treename,
goto err;
}
- if (strcmp(tree->value.opaque, treename) == 0)
+ if (tree->value.opaque != NULL &&
+ strcmp(tree->value.opaque, treename) == 0)
return tree;
err->error = NFT_PARSE_EMISSINGNODE;
--
1.7.10.4
next reply other threads:[~2015-03-02 19:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 19:58 Alvaro Neira Ayuso [this message]
2015-03-02 23:35 ` [libnftnl PATCH] mxml: test if the root node name is initialized before to compare it Pablo Neira Ayuso
2015-03-03 13:45 ` Álvaro Neira Ayuso
2015-03-04 19:03 ` Pablo Neira Ayuso
2015-03-04 19:20 ` Pablo Neira Ayuso
2015-03-04 20:25 ` Álvaro Neira Ayuso
2015-03-05 20:52 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425326318-22936-1-git-send-email-alvaroneay@gmail.com \
--to=alvaroneay@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).