From: Patrick McHardy <kaber@trash.net>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org
Subject: [PATCH 1/3] netlink: fix use after free in netlink_get_table()
Date: Wed, 25 Mar 2015 21:00:25 +0000 [thread overview]
Message-ID: <1427317227-11313-1-git-send-email-kaber@trash.net> (raw)
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
src/netlink.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/netlink.c b/src/netlink.c
index 24dda67..f957295 100644
--- a/src/netlink.c
+++ b/src/netlink.c
@@ -953,19 +953,19 @@ int netlink_get_table(struct netlink_ctx *ctx, const struct handle *h,
nlt = alloc_nft_table(h);
err = mnl_nft_table_get(nf_sock, nlt, 0);
- nft_table_free(nlt);
-
if (err < 0) {
netlink_io_error(ctx, loc,
"Could not receive table from kernel: %s",
strerror(errno));
- return err;
+ goto out;
}
ntable = netlink_delinearize_table(ctx, nlt);
table->flags = ntable->flags;
xfree(ntable);
- return 0;
+out:
+ nft_table_free(nlt);
+ return err;
}
int netlink_list_table(struct netlink_ctx *ctx, const struct handle *h,
--
2.1.0
next reply other threads:[~2015-03-25 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 21:00 Patrick McHardy [this message]
2015-03-25 21:00 ` [PATCH 2/3] netlink_delinarize: fix payload dependency killing of link layer dependencies Patrick McHardy
2015-03-25 21:00 ` [PATCH 3/3] parser: remove duplicated grammar for chain policy Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427317227-11313-1-git-send-email-kaber@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).