From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
pablo@netfilter.org, jiri@resnulli.us
Subject: Re: [PATCH 3/4] netfilter: Pass socket pointer down through okfn().
Date: Tue, 07 Apr 2015 16:44:29 +0200 [thread overview]
Message-ID: <1428417869.2928.1.camel@stressinduktion.org> (raw)
In-Reply-To: <20150405.221904.606225054570296194.davem@davemloft.net>
On So, 2015-04-05 at 22:19 -0400, David Miller wrote:
> --- a/include/linux/netfilter.h
> +++ b/include/linux/netfilter.h
> @@ -54,7 +54,7 @@ struct nf_hook_state {
> struct net_device *in;
> struct net_device *out;
> struct sock *sk;
> - int (*okfn)(struct sk_buff *);
> + int (*okfn)(struct sock *, struct sk_buff *);
> };
If we give okfn the signature int (*okfn)(struct nf_hook_state *); then
we would not need to touch anything else to enhance this.
What do you think?
Thanks,
Hannes
next prev parent reply other threads:[~2015-04-07 14:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 2:19 [PATCH 3/4] netfilter: Pass socket pointer down through okfn() David Miller
2015-04-07 14:44 ` Hannes Frederic Sowa [this message]
2015-04-07 15:35 ` Pablo Neira Ayuso
2015-04-07 16:01 ` David Miller
2015-04-07 18:56 ` Hannes Frederic Sowa
2015-04-07 19:18 ` David Miller
2015-04-07 15:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428417869.2928.1.camel@stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).