From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Subject: Re: [PATCH 3/4] netfilter: Pass socket pointer down through okfn().
Date: Tue, 07 Apr 2015 16:44:29 +0200
Message-ID: <1428417869.2928.1.camel@stressinduktion.org>
References: <20150405.221904.606225054570296194.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
	pablo@netfilter.org, jiri@resnulli.us
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
In-Reply-To: <20150405.221904.606225054570296194.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-Id: netfilter-devel.vger.kernel.org

On So, 2015-04-05 at 22:19 -0400, David Miller wrote:
> --- a/include/linux/netfilter.h
> +++ b/include/linux/netfilter.h
> @@ -54,7 +54,7 @@ struct nf_hook_state {
>  	struct net_device *in;
>  	struct net_device *out;
>  	struct sock *sk;
> -	int (*okfn)(struct sk_buff *);
> +	int (*okfn)(struct sock *, struct sk_buff *);
>  };

If we give okfn the signature int (*okfn)(struct nf_hook_state *); then
we would not need to touch anything else to enhance this.

What do you think?

Thanks,
Hannes