From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Subject: Re: [PATCH 4/4] udp_tunnel: Pass UDP socket down through udp_tunnel{,6}_xmit_skb(). Date: Wed, 08 Apr 2015 17:03:02 +0200 Message-ID: <1428505382.873082.250792005.6B704B17@webmail.messagingengine.com> References: <1428421534.2928.3.camel@stressinduktion.org> <20150407.153044.772260953305341361.davem@davemloft.net> <1428449099.869458.250499317.11121567@webmail.messagingengine.com> <20150407.221328.1961195097281515709.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: rick.jones2@hp.com, tom@herbertland.com, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, pablo@netfilter.org, jiri@resnulli.us To: David Miller Return-path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35891 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753411AbbDHPDD (ORCPT ); Wed, 8 Apr 2015 11:03:03 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 4E7E120BFB for ; Wed, 8 Apr 2015 11:02:59 -0400 (EDT) In-Reply-To: <20150407.221328.1961195097281515709.davem@davemloft.net> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Wed, Apr 8, 2015, at 04:13, David Miller wrote: > From: Hannes Frederic Sowa > Date: Wed, 08 Apr 2015 01:24:59 +0200 > > > There is one small problem which already was present before this patch > > because of my change b6a7719aedd7e5 ("ipv4: hash net ptr into > > fragmentation bucket selection"). It uses sock_net in iptunnel_xmit, > > which causes a NULL ptr panic. This patchset did make it more visible > > because of the explicit NULL passing but the bug was introduced by my > > patch. > > > > Just wanted to let you know if reports are coming in - I fix it up > > tomorrow. I will also explore the possibility to give each tunnel at > > least a raw socket, what Tom proposed. > > > > Rick Jones identified this, thanks! > > Looking into this I also notice that ipip6_tunnel_xmit() passes > in skb->sk, that needs to be NULL too. > > Want to take care of that along with your sock_net() fix? Yep, did so and used the simple solution for now. I am currently trying to check if it makes sense to remove ignore_df and always use the socket context. Bye, Hannes