From: Richard Weinberger <richard@nod.at>
To: netdev@vger.kernel.org
Cc: linux-wireless@vger.kernel.org, coreteam@netfilter.org,
netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
sameo@linux.intel.com, aloisio.almeida@openbossa.org,
lauro.venancio@openbossa.org, davem@davemloft.net,
kadlec@blackhole.kfki.hu, kaber@trash.net, pablo@netfilter.org,
Richard Weinberger <richard@nod.at>
Subject: [PATCH 4/5 v2] netfilter: Fix format string of nfnetlink_queue proc file
Date: Thu, 9 Apr 2015 23:57:16 +0200 [thread overview]
Message-ID: <1428616637-21690-4-git-send-email-richard@nod.at> (raw)
In-Reply-To: <1428616637-21690-1-git-send-email-richard@nod.at>
The printed values are all of type unsigned integer, therefore use
%u instead of %d. Otherwise an user can face negative values.
Fixes:
$ cat /proc/net/netfilter/nfnetlink_queue
0 29508 278 2 65531 0 2004213241 -2129885586 1
1 -27747 0 2 65531 0 0 0 1
2 -27748 0 2 65531 0 0 0 1
Signed-off-by: Richard Weinberger <richard@nod.at>
---
net/netfilter/nfnetlink_queue_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nfnetlink_queue_core.c b/net/netfilter/nfnetlink_queue_core.c
index 0aba0b9..017e3cd 100644
--- a/net/netfilter/nfnetlink_queue_core.c
+++ b/net/netfilter/nfnetlink_queue_core.c
@@ -1241,7 +1241,7 @@ static int seq_show(struct seq_file *s, void *v)
{
const struct nfqnl_instance *inst = v;
- seq_printf(s, "%5d %6d %5d %1d %5d %5d %5d %8d %2d\n",
+ seq_printf(s, "%5u %6u %5u %1u %5u %5u %5u %8u %2d\n",
inst->queue_num,
inst->peer_portid, inst->queue_total,
inst->copy_mode, inst->copy_range,
--
1.8.4.5
next prev parent reply other threads:[~2015-04-09 21:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 21:57 [PATCH 1/5 v2] netlink: Fix portid type in netlink_notify Richard Weinberger
2015-04-09 21:57 ` [PATCH 2/5 v2] nfc: Fix portid type in urelease_work Richard Weinberger
2015-04-09 21:57 ` [PATCH 3/5 v2] netfilter: Fix portid types Richard Weinberger
2015-04-09 21:57 ` Richard Weinberger [this message]
2015-04-09 21:57 ` [PATCH 5/5 v2] netfilter: Fix format string of nfnetlink_log proc file Richard Weinberger
2015-04-09 22:39 ` Joe Perches
2015-04-09 22:43 ` Steven Rostedt
2015-04-10 7:31 ` Richard Weinberger
2015-04-10 19:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428616637-21690-4-git-send-email-richard@nod.at \
--to=richard@nod.at \
--cc=aloisio.almeida@openbossa.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).