netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] netfilter: Fix format string of nfnetlink_log proc file
@ 2015-04-10  7:30 Richard Weinberger
  0 siblings, 0 replies; only message in thread
From: Richard Weinberger @ 2015-04-10  7:30 UTC (permalink / raw)
  To: netdev
  Cc: coreteam, netfilter-devel, linux-kernel, davem, kadlec, kaber,
	pablo, Richard Weinberger

The printed values are all of type unsigned integer, therefore use
%u instead of %d. Otherwise an user can face negative values.

Signed-off-by: Richard Weinberger <richard@nod.at>
---
Pablo,

this is an updated version of
"[PATCH 5/5 v2] netfilter: Fix format string of nfnetlink_log proc file",
now it is based on net-next.
Sorry for the troube.

Thanks,
//richard
---
 net/netfilter/nfnetlink_log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c
index 5c79735..3ad9126 100644
--- a/net/netfilter/nfnetlink_log.c
+++ b/net/netfilter/nfnetlink_log.c
@@ -1007,7 +1007,7 @@ static int seq_show(struct seq_file *s, void *v)
 {
 	const struct nfulnl_instance *inst = v;
 
-	seq_printf(s, "%5d %6d %5d %1d %5d %6d %2d\n",
+	seq_printf(s, "%5u %6u %5u %1u %5u %6u %2u\n",
 		   inst->group_num,
 		   inst->peer_portid, inst->qlen,
 		   inst->copy_mode, inst->copy_range,
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-04-10  7:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-10  7:30 [PATCH v3] netfilter: Fix format string of nfnetlink_log proc file Richard Weinberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).