From: Patrick McHardy <kaber@trash.net>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org
Subject: [PATCH 10/14] netfilter: nf_tables: convert sets to u32 data pointers
Date: Sat, 11 Apr 2015 02:27:35 +0100 [thread overview]
Message-ID: <1428715659-31358-11-git-send-email-kaber@trash.net> (raw)
In-Reply-To: <1428715659-31358-1-git-send-email-kaber@trash.net>
Simple conversion to use u32 pointers to the beginning of the data
area to keep follow up patches smaller.
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
include/net/netfilter/nf_tables.h | 4 ++--
net/netfilter/nft_hash.c | 11 +++++------
net/netfilter/nft_rbtree.c | 3 +--
3 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h
index fca0b5d..efcf46d 100644
--- a/include/net/netfilter/nf_tables.h
+++ b/include/net/netfilter/nf_tables.h
@@ -231,10 +231,10 @@ struct nft_expr;
*/
struct nft_set_ops {
bool (*lookup)(const struct nft_set *set,
- const struct nft_data *key,
+ const u32 *key,
const struct nft_set_ext **ext);
bool (*update)(struct nft_set *set,
- const struct nft_data *key,
+ const u32 *key,
void *(*new)(struct nft_set *,
const struct nft_expr *,
struct nft_regs *),
diff --git a/net/netfilter/nft_hash.c b/net/netfilter/nft_hash.c
index c26844d..c4b4475 100644
--- a/net/netfilter/nft_hash.c
+++ b/net/netfilter/nft_hash.c
@@ -36,7 +36,7 @@ struct nft_hash_elem {
struct nft_hash_cmp_arg {
const struct nft_set *set;
- const struct nft_data *key;
+ const u32 *key;
u8 genmask;
};
@@ -71,8 +71,7 @@ static inline int nft_hash_cmp(struct rhashtable_compare_arg *arg,
return 0;
}
-static bool nft_hash_lookup(const struct nft_set *set,
- const struct nft_data *key,
+static bool nft_hash_lookup(const struct nft_set *set, const u32 *key,
const struct nft_set_ext **ext)
{
struct nft_hash *priv = nft_set_priv(set);
@@ -90,7 +89,7 @@ static bool nft_hash_lookup(const struct nft_set *set,
return !!he;
}
-static bool nft_hash_update(struct nft_set *set, const struct nft_data *key,
+static bool nft_hash_update(struct nft_set *set, const u32 *key,
void *(*new)(struct nft_set *,
const struct nft_expr *,
struct nft_regs *regs),
@@ -134,7 +133,7 @@ static int nft_hash_insert(const struct nft_set *set,
struct nft_hash_cmp_arg arg = {
.genmask = nft_genmask_next(read_pnet(&set->pnet)),
.set = set,
- .key = &elem->key,
+ .key = elem->key.data,
};
return rhashtable_lookup_insert_key(&priv->ht, &arg, &he->node,
@@ -158,7 +157,7 @@ static void *nft_hash_deactivate(const struct nft_set *set,
struct nft_hash_cmp_arg arg = {
.genmask = nft_genmask_next(read_pnet(&set->pnet)),
.set = set,
- .key = &elem->key,
+ .key = elem->key.data,
};
rcu_read_lock();
diff --git a/net/netfilter/nft_rbtree.c b/net/netfilter/nft_rbtree.c
index b398f1a..b888e0c 100644
--- a/net/netfilter/nft_rbtree.c
+++ b/net/netfilter/nft_rbtree.c
@@ -30,8 +30,7 @@ struct nft_rbtree_elem {
};
-static bool nft_rbtree_lookup(const struct nft_set *set,
- const struct nft_data *key,
+static bool nft_rbtree_lookup(const struct nft_set *set, const u32 *key,
const struct nft_set_ext **ext)
{
const struct nft_rbtree *priv = nft_set_priv(set);
--
2.1.0
next prev parent reply other threads:[~2015-04-11 1:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-11 1:27 [PATCH 00/14] netfilter: nf_tables: concatenation support Patrick McHardy
2015-04-11 1:27 ` [PATCH 01/14] netfilter: nf_tables: validate len in nft_validate_data_load() Patrick McHardy
2015-04-11 1:27 ` [PATCH 02/14] netfilter: nf_tables: rename nft_validate_data_load() Patrick McHardy
2015-04-11 1:27 ` [PATCH 03/14] netfilter: nft_lookup: use nft_validate_register_store() to validate types Patrick McHardy
2015-04-11 1:27 ` [PATCH 04/14] netfilter: nf_tables: kill nft_validate_output_register() Patrick McHardy
2015-04-11 1:27 ` [PATCH 05/14] netfilter: nf_tables: introduce nft_validate_register_load() Patrick McHardy
2015-04-11 1:27 ` [PATCH 06/14] netfilter: nf_tables: get rid of NFT_REG_VERDICT usage Patrick McHardy
2015-04-11 1:27 ` [PATCH 07/14] netfilter: nf_tables: use struct nft_verdict within struct nft_data Patrick McHardy
2015-04-11 1:27 ` [PATCH 08/14] netfilter: nf_tables: convert expressions to u32 register pointers Patrick McHardy
2015-04-11 1:27 ` [PATCH 09/14] netfilter: nf_tables: kill nft_data_cmp() Patrick McHardy
2015-04-11 1:27 ` Patrick McHardy [this message]
2015-04-11 1:27 ` [PATCH 11/14] netfilter: nf_tables: add register parsing/dumping helpers Patrick McHardy
2015-04-11 1:27 ` [PATCH 12/14] netfilter: nf_tables: switch registers to 32 bit addressing Patrick McHardy
2015-04-11 1:27 ` [PATCH 13/14] netfilter: nf_tables: support variable sized data in nft_data_init() Patrick McHardy
2015-04-11 1:27 ` [PATCH 14/14] netfilter: nf_tables: variable sized set element keys / data Patrick McHardy
2015-04-11 13:47 ` [PATCH 00/14] netfilter: nf_tables: concatenation support Pablo Neira Ayuso
2015-04-11 13:47 ` Patrick McHardy
2015-04-13 18:07 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428715659-31358-11-git-send-email-kaber@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).