From: Eric Leblond <eric@regit.org>
To: Felix Janda <felix.janda@posteo.de>, netfilter-devel@vger.kernel.org
Subject: Re: [ulogd2 PATCHv2] Use stdint types everywhere
Date: Wed, 24 Jun 2015 09:37:12 +0200 [thread overview]
Message-ID: <1435131432.18335.7.camel@regit.org> (raw)
In-Reply-To: <20150623172708.GA1343@euler>
Hi,
On Tue, 2015-06-23 at 19:27 +0200, Felix Janda wrote:
> Signed-off-by: Felix Janda <felix.janda@posteo.de>
> ---
> v2: Ensure that <stdint.h> is included where used. Only the changes
> to
> the headers are different from v1.
> ---
...
> @@ -594,14 +594,14 @@ static int _interp_udp(struct
> ulogd_pluginstance *pi, struct udphdr *udph,
>
> /* Section 3.1. SCTP Common Header Format */
> typedef struct sctphdr {
> - __be16 source;
> - __be16 dest;
> - __be32 vtag;
> - __be32 checksum;
> + uint16_t source;
> + uint16_t dest;
> + uint32_t vtag;
> + uint32_t checksum;
> } __attribute__((packed)) sctp_sctphdr_t;
Sorry for not mentioning that in previous mail but I'm not comfortable
with this hunk. We are loosing synchronization with upstream definition
as well as some information on endianness.
Could you repost the patch removing this hunk?
BR,
--
Eric Leblond <eric@regit.org>
Blog: https://home.regit.org/
prev parent reply other threads:[~2015-06-24 7:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 17:27 [ulogd2 PATCHv2] Use stdint types everywhere Felix Janda
2015-06-24 7:37 ` Eric Leblond [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435131432.18335.7.camel@regit.org \
--to=eric@regit.org \
--cc=felix.janda@posteo.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).