From: Eric Leblond <eric@regit.org>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org, Eric Leblond <eric@regit.org>
Subject: [PATCH nft] payload: reorder case in a switch for consistency
Date: Fri, 26 Jun 2015 11:55:21 +0200 [thread overview]
Message-ID: <1435312521-8184-1-git-send-email-eric@regit.org> (raw)
In-Reply-To: <20150626085441.GB10981@acer.localdomain>
As pointed out by Patrick McHardy the order in the inet switch
in payload_gen_dependency was not consistent.
Signed-off-by: Eric Leblond <eric@regit.org>
---
src/payload.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/payload.c b/src/payload.c
index e67ef17..5f8c4fe 100644
--- a/src/payload.c
+++ b/src/payload.c
@@ -204,12 +204,12 @@ int payload_gen_dependency(struct eval_ctx *ctx, const struct expr *expr,
switch (ctx->pctx.family) {
case NFPROTO_INET:
switch (expr->payload.base) {
- case PROTO_BASE_TRANSPORT_HDR:
- desc = &proto_inet_service;
- break;
case PROTO_BASE_LL_HDR:
desc = &proto_inet;
break;
+ case PROTO_BASE_TRANSPORT_HDR:
+ desc = &proto_inet_service;
+ break;
default:
break;
}
--
2.1.4
next prev parent reply other threads:[~2015-06-26 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 8:45 [PATCH nft] payload: fix transport matching with no network layer info in bridge family Pablo Neira Ayuso
2015-06-26 8:54 ` Patrick McHardy
2015-06-26 9:55 ` Eric Leblond [this message]
2015-06-30 0:03 ` [PATCH nft] payload: reorder case in a switch for consistency Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435312521-8184-1-git-send-email-eric@regit.org \
--to=eric@regit.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).