From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net
Subject: [PATCH nft,v3 4/7] src: early allocation of the set ID
Date: Thu, 2 Jul 2015 20:25:09 +0200 [thread overview]
Message-ID: <1435861512-23572-5-git-send-email-pablo@netfilter.org> (raw)
In-Reply-To: <1435861512-23572-1-git-send-email-pablo@netfilter.org>
By when the set is created, so element in the batch use this set ID as
reference.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/netlink.c | 4 ----
src/rule.c | 5 +++++
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/netlink.c b/src/netlink.c
index 4b57aab..1f28bf6 100644
--- a/src/netlink.c
+++ b/src/netlink.c
@@ -1117,9 +1117,6 @@ static int netlink_add_set_compat(struct netlink_ctx *ctx,
return err;
}
-/* internal ID to uniquely identify a set in the batch */
-static uint32_t set_id;
-
static int netlink_add_set_batch(struct netlink_ctx *ctx,
const struct handle *h, struct set *set)
{
@@ -1143,7 +1140,6 @@ static int netlink_add_set_batch(struct netlink_ctx *ctx,
if (set->gc_int)
nft_set_attr_set_u32(nls, NFT_SET_ATTR_GC_INTERVAL, set->gc_int);
- set->handle.set_id = ++set_id;
nft_set_attr_set_u32(nls, NFT_SET_ATTR_ID, set->handle.set_id);
if (!(set->flags & (SET_F_CONSTANT))) {
diff --git a/src/rule.c b/src/rule.c
index 838bd7e..7491ee7 100644
--- a/src/rule.c
+++ b/src/rule.c
@@ -56,6 +56,9 @@ void handle_merge(struct handle *dst, const struct handle *src)
dst->comment = xstrdup(src->comment);
}
+/* internal ID to uniquely identify a set in the batch */
+static uint32_t set_id;
+
struct set *set_alloc(const struct location *loc)
{
struct set *set;
@@ -64,6 +67,8 @@ struct set *set_alloc(const struct location *loc)
set->refcnt = 1;
if (loc != NULL)
set->location = *loc;
+
+ set->handle.set_id = ++set_id;
return set;
}
--
1.7.10.4
next prev parent reply other threads:[~2015-07-02 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 18:25 [PATCH nft,v3 0/7] cache consolidation Pablo Neira Ayuso
2015-07-02 18:25 ` [PATCH nft,v3 1/7] src: consolidate table cache Pablo Neira Ayuso
2015-07-02 18:25 ` [PATCH nft,v3 2/7] src: add table declaration to cache Pablo Neira Ayuso
2015-07-02 18:25 ` [PATCH nft,v3 3/7] src: consolidate set cache Pablo Neira Ayuso
2015-07-02 18:25 ` Pablo Neira Ayuso [this message]
2015-07-02 18:25 ` [PATCH nft,v3 5/7] segtree: pass element expression as parameter to set_to_intervals() Pablo Neira Ayuso
2015-07-02 18:25 ` [PATCH nft,v3 6/7] rule: use netlink_add_setelems() when creating literal sets Pablo Neira Ayuso
2015-07-02 18:25 ` [PATCH nft,v3 7/7] rule: fix use of intervals in set declarations Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435861512-23572-5-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).