From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net
Subject: [PATCH nft 2/2] netlink: don't call netlink_dump_*() from listing functions with --debug=netlink
Date: Wed, 12 Aug 2015 19:26:32 +0200 [thread overview]
Message-ID: <1439400392-30875-2-git-send-email-pablo@netfilter.org> (raw)
In-Reply-To: <1439400392-30875-1-git-send-email-pablo@netfilter.org>
Now that we always retrieve the object list to build a cache before executing
the command, this results in fully listing of existing objects in the kernel.
This is confusing when adding a simple rule, so better not to call
netlink_dump_*() from listing functions.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
Applies on top of the cache-consolidation branch.
src/netlink.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/src/netlink.c b/src/netlink.c
index 0fb7b63..b71d04f 100644
--- a/src/netlink.c
+++ b/src/netlink.c
@@ -913,7 +913,6 @@ static struct table *netlink_delinearize_table(struct netlink_ctx *ctx,
{
struct table *table;
- netlink_dump_table(nlt);
table = table_alloc();
table->handle.family =
nft_table_attr_get_u32(nlt, NFT_TABLE_ATTR_FAMILY);
@@ -1226,7 +1225,6 @@ static int list_set_cb(struct nft_set *nls, void *arg)
struct netlink_ctx *ctx = arg;
struct set *set;
- netlink_dump_set(nls);
set = netlink_delinearize_set(ctx, nls);
if (set == NULL)
return -1;
@@ -1263,7 +1261,6 @@ int netlink_get_set(struct netlink_ctx *ctx, const struct handle *h,
int err;
nls = alloc_nft_set(h);
- netlink_dump_set(nls);
err = mnl_nft_set_get(nf_sock, nls);
if (err < 0) {
nft_set_free(nls);
@@ -1504,7 +1501,6 @@ int netlink_get_setelems(struct netlink_ctx *ctx, const struct handle *h,
int err;
nls = alloc_nft_set(h);
- netlink_dump_set(nls);
err = mnl_nft_setelem_get(nf_sock, nls);
if (err < 0) {
--
1.7.10.4
prev parent reply other threads:[~2015-08-12 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 17:26 [PATCH nft 1/2] evaluate: display error on unexisting chain when listing Pablo Neira Ayuso
2015-08-12 17:26 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439400392-30875-2-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).