From: Maxime Bizon <mbizon@freebox.fr>
To: Tom Herbert <tom@herbertland.com>
Cc: netdev <netdev@vger.kernel.org>, davem <davem@davemloft.net>,
kaber <kaber@trash.net>,
pablo@netfilter.org,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH v2] netfilter: fix bad checksum on IPv6 when NAT is performed
Date: Thu, 08 Oct 2015 23:26:34 +0200 [thread overview]
Message-ID: <1444339594.14655.392.camel@sakura.staff.proxad.net> (raw)
In-Reply-To: <CALx6S37AdH=icFEqXjH5hDJ2O0dkwLEx6_KqpFkoPYF2sr1N_Q@mail.gmail.com>
On Thu, 2015-10-08 at 14:09 -0700, Tom Herbert wrote:
> I think inet_proto_csum_replace16 should be called here.
inet_proto_csum_replace16() wants a non NULL checksum pointer to update,
and there is no such thing here.
I could pass a dummy value, but inet_proto_csum_replace16() will do
twice more work for nothing
or I could modify inet_proto_csum_replace16() to allow a NULL sum
argument.
--
Maxime
next prev parent reply other threads:[~2015-10-08 21:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 14:23 [PATCH] netfilter: fix bad checksum on IPv6 when NAT is performed Maxime Bizon
2015-10-08 20:19 ` Maxime Bizon
2015-10-08 20:26 ` [PATCH v2] " Maxime Bizon
2015-10-08 21:09 ` Tom Herbert
2015-10-08 21:26 ` Maxime Bizon [this message]
2015-10-08 22:11 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444339594.14655.392.camel@sakura.staff.proxad.net \
--to=mbizon@freebox.fr \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).