[PATCH] ipset tool: Fix link with libtool >= 2.4.4

[PATCH] ipset tool: Fix link with libtool >= 2.4.4

[Olivier Blin]

Hi,

This is a simple patch to fix link of ipset with latest libtool
versions.

Cheers

[PATCH] Fix link with libtool >= 2.4.4

[Olivier Blin]

As of libtool-2.4.4, -ldl is no longer prepended to LIBS.
Since types.c needs dlopen() and dlerror(), use LIBADD_DLOPEN, as
suggested in libtool-2.4.4 release notes.
---
 lib/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Makefile.am b/lib/Makefile.am
index 36f60b0..4a376ca 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -24,7 +24,7 @@ lib_LTLIBRARIES = libipset.la
 include $(top_srcdir)/lib/Make_extra.am
 
 libipset_la_LDFLAGS = -Wl,--version-script=$(top_srcdir)/lib/libipset.map -version-info $(LIBVERSION)
-libipset_la_LIBADD  = ${libmnl_LIBS} $(IPSET_SETTYPE_STATIC_OBJECTS)
+libipset_la_LIBADD  = ${libmnl_LIBS} $(IPSET_SETTYPE_STATIC_OBJECTS) $(LIBADD_DLOPEN)
 libipset_la_SOURCES = \
 	data.c \
 	errcode.c \
-- 
2.6.4

Re: [PATCH] ipset tool: Fix link with libtool >= 2.4.4

[Jozsef Kadlecsik]

Hi,

On Thu, 7 Jan 2016, Olivier Blin wrote:

> This is a simple patch to fix link of ipset with latest libtool
> versions.

Is the patch compatible with non-latest libtool versions?

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary

Re: [PATCH] ipset tool: Fix link with libtool >= 2.4.4

[Olivier Blin]

Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> writes:

> On Thu, 7 Jan 2016, Olivier Blin wrote:
>
>> This is a simple patch to fix link of ipset with latest libtool
>> versions.
>
> Is the patch compatible with non-latest libtool versions?

Hi Jozsef,

I have tested this with libtool 2.4.2 and 2.4.6 versions, ipset builds
fine with both.

The only downside is that -ldl is now passed twice with older libtool
versions, but this should not be a problem.

Thanks

-- 
Olivier Blin - blino

Re: [PATCH] ipset tool: Fix link with libtool >= 2.4.4

[Kadlecsik József]

On Thu, 7 Jan 2016, Olivier Blin wrote:

> Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> writes:
> 
> > On Thu, 7 Jan 2016, Olivier Blin wrote:
> >
> >> This is a simple patch to fix link of ipset with latest libtool
> >> versions.
> >
> > Is the patch compatible with non-latest libtool versions?
> 
> I have tested this with libtool 2.4.2 and 2.4.6 versions, ipset builds
> fine with both.
> 
> The only downside is that -ldl is now passed twice with older libtool
> versions, but this should not be a problem.

The patch is applied, thank you.

Best regards,
Jozsef
--
E-mail : kadlecsik.jozsef@wigner.mta.hu
PGP key: http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address: Wigner Research Centre for Physics, Hungarian Academy of Sciences
         H-1525 Budapest 114, POB. 49, Hungary