From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: arturo.borrero.glez@gmail.com, fw@strlen.de
Subject: [PATCH nft] parser_bison: initializer_expr must use rhs_expr
Date: Tue, 12 Jan 2016 13:48:33 +0100 [thread overview]
Message-ID: <1452602913-18352-1-git-send-email-pablo@netfilter.org> (raw)
Use rhs_expr and list_rhs_expr as possible occurrences of
initializer_expr since we may only find constant expressions on the
right hand side of the assignment.
Fixes: 2a5d44d8b3c (parser: get rid of multiton_expr from lhs relational expression)
Reported-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/parser_bison.y | 20 ++------------------
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/src/parser_bison.y b/src/parser_bison.y
index fcd4813..fcf84b9 100644
--- a/src/parser_bison.y
+++ b/src/parser_bison.y
@@ -490,8 +490,6 @@ static void location_update(struct location *loc, struct location *rhs, int n)
%type <expr> stmt_expr concat_stmt_expr map_stmt_expr
%destructor { expr_free($$); } stmt_expr concat_stmt_expr map_stmt_expr
-%type <expr> list_expr
-%destructor { expr_free($$); } list_expr
%type <expr> concat_expr
%destructor { expr_free($$); } concat_expr
@@ -1854,20 +1852,6 @@ concat_expr : basic_expr
}
;
-list_expr : basic_expr COMMA basic_expr
- {
- $$ = list_expr_alloc(&@$);
- compound_expr_add($$, $1);
- compound_expr_add($$, $3);
- }
- | list_expr COMMA basic_expr
- {
- $1->location = @$;
- compound_expr_add($1, $3);
- $$ = $1;
- }
- ;
-
prefix_rhs_expr : basic_rhs_expr SLASH NUM
{
$$ = prefix_expr_alloc(&@$, $1, $3);
@@ -1976,8 +1960,8 @@ set_rhs_expr : concat_rhs_expr
| verdict_expr
;
-initializer_expr : expr
- | list_expr
+initializer_expr : rhs_expr
+ | list_rhs_expr
;
relational_expr : expr /* implicit */ rhs_expr
--
2.1.4
next reply other threads:[~2016-01-12 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 12:48 Pablo Neira Ayuso [this message]
2016-01-12 13:05 ` [PATCH nft] parser_bison: initializer_expr must use rhs_expr Florian Westphal
2016-01-13 8:52 ` Arturo Borrero Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452602913-18352-1-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).