From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net, fw@strlen.de, benoit.knecht@fsfe.org
Subject: [PATCH nft] proto: use parameter-problem for icmpv6 type
Date: Mon, 1 Feb 2016 14:51:02 +0100 [thread overview]
Message-ID: <1454334662-4351-1-git-send-email-pablo@netfilter.org> (raw)
To keep it consistent with icmpv4 naming.
Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=911
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/proto.c | 2 +-
tests/py/ip6/icmpv6.t | 1 +
tests/py/ip6/icmpv6.t.payload.ip6 | 8 ++++++++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/proto.c b/src/proto.c
index 0cd9fdb..0ed98ed 100644
--- a/src/proto.c
+++ b/src/proto.c
@@ -542,7 +542,7 @@ static const struct symbol_table icmp6_type_tbl = {
SYMBOL("destination-unreachable", ICMP6_DST_UNREACH),
SYMBOL("packet-too-big", ICMP6_PACKET_TOO_BIG),
SYMBOL("time-exceeded", ICMP6_TIME_EXCEEDED),
- SYMBOL("param-problem", ICMP6_PARAM_PROB),
+ SYMBOL("parameter-problem", ICMP6_PARAM_PROB),
SYMBOL("echo-request", ICMP6_ECHO_REQUEST),
SYMBOL("echo-reply", ICMP6_ECHO_REPLY),
SYMBOL("mld-listener-query", MLD_LISTENER_QUERY),
diff --git a/tests/py/ip6/icmpv6.t b/tests/py/ip6/icmpv6.t
index af40bf7..6892273 100644
--- a/tests/py/ip6/icmpv6.t
+++ b/tests/py/ip6/icmpv6.t
@@ -17,6 +17,7 @@ icmpv6 type nd-router-advert accept;ok
icmpv6 type nd-neighbor-solicit accept;ok
icmpv6 type nd-neighbor-advert accept;ok
icmpv6 type nd-redirect accept;ok
+icmpv6 type parameter-problem accept;ok
icmpv6 type router-renumbering accept;ok
icmpv6 type {destination-unreachable, time-exceeded, nd-router-solicit} accept;ok
icmpv6 type {router-renumbering, mld-listener-reduction, time-exceeded, nd-router-solicit} accept;ok
diff --git a/tests/py/ip6/icmpv6.t.payload.ip6 b/tests/py/ip6/icmpv6.t.payload.ip6
index 55af9d8..d13b799 100644
--- a/tests/py/ip6/icmpv6.t.payload.ip6
+++ b/tests/py/ip6/icmpv6.t.payload.ip6
@@ -102,6 +102,14 @@ ip6 test-ip6 input
[ cmp eq reg 1 0x00000089 ]
[ immediate reg 0 accept ]
+# icmpv6 type parameter-problem accept
+ip6 test-ip6 input
+ [ payload load 1b @ network header + 6 => reg 1 ]
+ [ cmp eq reg 1 0x0000003a ]
+ [ payload load 1b @ transport header + 0 => reg 1 ]
+ [ cmp eq reg 1 0x00000004 ]
+ [ immediate reg 0 accept ]
+
# icmpv6 type router-renumbering accept
ip6 test-ip6 input
[ payload load 1b @ network header + 6 => reg 1 ]
--
2.1.4
reply other threads:[~2016-02-01 13:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454334662-4351-1-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=benoit.knecht@fsfe.org \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).