netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH 04/10] netfilter: xt_osf: remove unused variable
Date: Tue,  8 Mar 2016 11:00:44 +0100	[thread overview]
Message-ID: <1457431250-3086-5-git-send-email-pablo@netfilter.org> (raw)
In-Reply-To: <1457431250-3086-1-git-send-email-pablo@netfilter.org>

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

While building with W=1 we got the warning:
net/netfilter/xt_osf.c:265:9: warning: variable 'loop_cont' set but not used

The local variable loop_cont was only initialized and then assigned a
value but was never used or checked after that.
While removing the variable, the case of OSFOPT_TS was not removed so
that it will serve as a reminder to us that we can do something in that
particular case.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 net/netfilter/xt_osf.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/netfilter/xt_osf.c b/net/netfilter/xt_osf.c
index 4e3c3af..2455b69 100644
--- a/net/netfilter/xt_osf.c
+++ b/net/netfilter/xt_osf.c
@@ -262,7 +262,6 @@ xt_osf_match_packet(const struct sk_buff *skb, struct xt_action_param *p)
 			if (f->opt[optnum].kind == (*optp)) {
 				__u32 len = f->opt[optnum].length;
 				const __u8 *optend = optp + len;
-				int loop_cont = 0;
 
 				fmatch = FMATCH_OK;
 
@@ -275,7 +274,6 @@ xt_osf_match_packet(const struct sk_buff *skb, struct xt_action_param *p)
 					mss = ntohs((__force __be16)mss);
 					break;
 				case OSFOPT_TS:
-					loop_cont = 1;
 					break;
 				}
 
-- 
2.1.4

  parent reply	other threads:[~2016-03-08 10:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08 10:00 [PATCH 00/10] Netfilter/IPVS updates for net-next Pablo Neira Ayuso
2016-03-08 10:00 ` [PATCH 01/10] netfilter: ipvs: Remove noisy debug print from ip_vs_del_service Pablo Neira Ayuso
2016-03-08 10:00 ` [PATCH 02/10] netfilter: ipvs: avoid unused variable warnings Pablo Neira Ayuso
2016-03-08 10:00 ` [PATCH 03/10] netfilter: meta: add PRANDOM support Pablo Neira Ayuso
2016-03-08 10:00 ` Pablo Neira Ayuso [this message]
2016-03-08 10:00 ` [PATCH 05/10] netfilter: nf_defrag_ipv4: Drop redundant ip_send_check() Pablo Neira Ayuso
2016-03-08 10:00 ` [PATCH 06/10] netfilter: xtables: prepare for on-demand hook register Pablo Neira Ayuso
2016-03-08 10:00 ` [PATCH 07/10] netfilter: xtables: don't hook tables by default Pablo Neira Ayuso
2016-03-08 10:00 ` [PATCH 08/10] netfilter: bridge: register hooks only when bridge interface is added Pablo Neira Ayuso
2016-03-08 10:00 ` [PATCH 09/10] netfilter: don't call hooks unless needed Pablo Neira Ayuso
2016-03-08 10:00 ` [PATCH 10/10] netfilter: nft_masq: support port range Pablo Neira Ayuso
2016-03-08 19:28 ` [PATCH 00/10] Netfilter/IPVS updates for net-next David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457431250-3086-5-git-send-email-pablo@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).