From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: fw@strlen.de
Subject: [nft 2/3] parser_bison: duplicate string returned by chain_type_name_lookup()
Date: Tue, 15 Mar 2016 17:33:17 +0100 [thread overview]
Message-ID: <1458059598-7470-2-git-send-email-pablo@netfilter.org> (raw)
In-Reply-To: <1458059598-7470-1-git-send-email-pablo@netfilter.org>
This chain type string is released via chain_free() since b7cb6915a88f,
so duplicate it so we don't try to release statically allocated memory.
Fixes: b7cb6915a88f ("rule: Remove memory leak")
Reported-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/parser_bison.y | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/parser_bison.y b/src/parser_bison.y
index 24c0969..0592b68 100644
--- a/src/parser_bison.y
+++ b/src/parser_bison.y
@@ -1101,7 +1101,7 @@ type_identifier : STRING { $$ = $1; }
hook_spec : TYPE STRING HOOK STRING dev_spec PRIORITY prio_spec
{
- $<chain>0->type = chain_type_name_lookup($2);
+ $<chain>0->type = xstrdup(chain_type_name_lookup($2));
if ($<chain>0->type == NULL) {
erec_queue(error(&@2, "unknown chain type %s", $2),
state->msgs);
--
2.1.4
next prev parent reply other threads:[~2016-03-15 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 16:33 [nft 1/3] parser_bison: simplify hook_spec rule Pablo Neira Ayuso
2016-03-15 16:33 ` Pablo Neira Ayuso [this message]
2016-03-15 16:33 ` [nft 3/3] parser_bison: release parsed type and hook name strings Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458059598-7470-2-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).