From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: fw@strlen.de
Subject: [nft 3/3] parser_bison: release parsed type and hook name strings
Date: Tue, 15 Mar 2016 17:33:18 +0100 [thread overview]
Message-ID: <1458059598-7470-3-git-send-email-pablo@netfilter.org> (raw)
In-Reply-To: <1458059598-7470-1-git-send-email-pablo@netfilter.org>
The scanner allocates memory for this, so release them given that we
don't attach them to any object.
==6277== 42 bytes in 6 blocks are definitely lost in loss record 2 of 4
==6277== at 0x4C28C20: malloc (vg_replace_malloc.c:296)
==6277== by 0x57AC9D9: strdup (strdup.c:42)
==6277== by 0x41B82D: xstrdup (utils.c:64)
==6277== by 0x41F510: nft_lex (scanner.l:511)
==6277== by 0x427FD1: nft_parse (parser_bison.c:3690)
==6277== by 0x4063AC: nft_run (main.c:231)
==6277== by 0x40600C: main (main.c:361)
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/parser_bison.y | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/parser_bison.y b/src/parser_bison.y
index 0592b68..9e86f26 100644
--- a/src/parser_bison.y
+++ b/src/parser_bison.y
@@ -1107,12 +1107,16 @@ hook_spec : TYPE STRING HOOK STRING dev_spec PRIORITY prio_spec
state->msgs);
YYERROR;
}
+ xfree($2);
+
$<chain>0->hookstr = chain_hookname_lookup($4);
if ($<chain>0->hookstr == NULL) {
erec_queue(error(&@4, "unknown chain hook %s", $4),
state->msgs);
YYERROR;
}
+ xfree($4);
+
$<chain>0->dev = $5;
$<chain>0->priority = $7;
$<chain>0->flags |= CHAIN_F_BASECHAIN;
--
2.1.4
prev parent reply other threads:[~2016-03-15 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 16:33 [nft 1/3] parser_bison: simplify hook_spec rule Pablo Neira Ayuso
2016-03-15 16:33 ` [nft 2/3] parser_bison: duplicate string returned by chain_type_name_lookup() Pablo Neira Ayuso
2016-03-15 16:33 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458059598-7470-3-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).