netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Subject: [PATCH nf v3] netfilter: x_tables: perform more sanity tests on rule set
Date: Tue, 22 Mar 2016 18:02:48 +0100	[thread overview]
Message-ID: <1458666173-24318-1-git-send-email-fw@strlen.de> (raw)

3rd iteration.

In addition to the problem reported by Ben Hawkes this also adds
a few checks to better validate ->next_offset and the target.

I checked that ip(6)tables-restore still works w. simple rulesets.

The reproducer doesn't work anymore w. patch #4 applied.


             reply	other threads:[~2016-03-22 17:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 17:02 Florian Westphal [this message]
2016-03-22 17:02 ` [PATCH 1/5] netfilter: x_tables: validate e->target_offset early Florian Westphal
2016-03-24 20:17   ` Pablo Neira Ayuso
2016-03-22 17:02 ` [PATCH 2/5] netfilter: x_tables: make sure e->next_offset covers remaining blob size Florian Westphal
2016-03-24 20:18   ` Pablo Neira Ayuso
2016-03-22 17:02 ` [PATCH 3/5] netfilter: x_tables: add and use xt_check_entry_target Florian Westphal
2016-03-24 20:18   ` Pablo Neira Ayuso
2016-03-25 11:45   ` Florian Westphal
2016-03-25 14:27     ` Pablo Neira Ayuso
2016-03-22 17:02 ` [PATCH 4/5] netfilter: x_tables: fix unconditional helper Florian Westphal
2016-03-24 20:18   ` Pablo Neira Ayuso
2016-03-22 17:02 ` [PATCH 5/5] netfilter: x_tables: don't move to non-existant next rule Florian Westphal
2016-03-22 17:22   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458666173-24318-1-git-send-email-fw@strlen.de \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).