netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Leblond <eric@regit.org>
To: Helmut Schaa <helmut.schaa@googlemail.com>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] ulogd: fix cross compilation errors with mysql_config
Date: Thu, 31 Mar 2016 08:52:56 +0200	[thread overview]
Message-ID: <1459407176.13447.14.camel@regit.org> (raw)
In-Reply-To: <1458312204-2874-1-git-send-email-helmut.schaa@googlemail.com>

Hello Helmut,

On Fri, 2016-03-18 at 15:43 +0100, Helmut Schaa wrote:
> When cross-compiling ulogd, mysql_config and pg_config will return
> build host
> configuration not build target configuration. This leads to build
> failures
> if mysql_config is installed on the host system but mysql is not
> available
> on the build target.
> 
> Fix this by not using mysql_config and pg_config for cross-
> compilation.

Applied, thanks!

BR,

> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> ---
>  acinclude.m4 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/acinclude.m4 b/acinclude.m4
> index 56d47b8..bd21255 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -35,7 +35,7 @@ if test "$pg_prefix" != "no"; then
>  AC_MSG_CHECKING([for PostgreSQL pg_config program])
>  for d in $pg_prefix/bin /usr/bin /usr/local/bin /usr/local/pgsql/bin
> /opt/pgsql/bin /opt/packages/pgsql/bin
>  do
> -	if test -x $d/pg_config
> +	if test -x $d/pg_config -a "$cross_compiling" = "no";
>  	then
>  		AC_MSG_RESULT(found pg_config in $d)
>  		PQINCPATH=`$d/pg_config --includedir`
> @@ -130,7 +130,7 @@ if test "$my_prefix" != "no"; then
>  AC_MSG_CHECKING([for MySQL mysql_config program])
>  for d in $my_prefix/bin /usr/bin /usr/local/bin /usr/local/mysql/bin
> /opt/mysql/bin /opt/packages/mysql/bin
>  do
> -	if test -x $d/mysql_config
> +	if test -x $d/mysql_config -a "$cross_compiling" = "no";
>  	then
>  		AC_MSG_RESULT(found mysql_config in $d)
>  		MYSQL_INC=`$d/mysql_config --include`
-- 
Eric Leblond <eric@regit.org>


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2016-03-31  7:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18 14:43 [PATCH] ulogd: fix cross compilation errors with mysql_config Helmut Schaa
2016-03-31  6:52 ` Eric Leblond [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459407176.13447.14.camel@regit.org \
    --to=eric@regit.org \
    --cc=helmut.schaa@googlemail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).