* [PATCH libnftnl] rule: fix leaks in NFTNL_RULE_USERDATA
@ 2016-04-15 10:35 Pablo Neira Ayuso
0 siblings, 0 replies; only message in thread
From: Pablo Neira Ayuso @ 2016-04-15 10:35 UTC (permalink / raw)
To: netfilter-devel; +Cc: carlosfg
Fix leaks in nftnl_rule_free() and nftnl_rule_set_data().
Reported-by: Carlos Falgueras García <carlosfg@riseup.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/rule.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/rule.c b/src/rule.c
index 3a32bf6..9c09127 100644
--- a/src/rule.c
+++ b/src/rule.c
@@ -75,6 +75,8 @@ void nftnl_rule_free(struct nftnl_rule *r)
xfree(r->table);
if (r->chain != NULL)
xfree(r->chain);
+ if (r->user.data != NULL)
+ xfree(r->user.data);
xfree(r);
}
@@ -162,6 +164,9 @@ void nftnl_rule_set_data(struct nftnl_rule *r, uint16_t attr,
r->position = *((uint64_t *)data);
break;
case NFTNL_RULE_USERDATA:
+ if (r->user.data != NULL)
+ xfree(r->user.data);
+
r->user.data = (void *)data;
r->user.len = data_len;
break;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-04-15 10:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-15 10:35 [PATCH libnftnl] rule: fix leaks in NFTNL_RULE_USERDATA Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).