netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Subject: [PATCH nf-next 0/3] netfilter: remove per-netns conntrack tables, part 3
Date: Mon,  9 May 2016 16:24:29 +0200	[thread overview]
Message-ID: <1462803872-13497-1-git-send-email-fw@strlen.de> (raw)

This series removes the per-namespace duplication of the NAT bysource table.

We use one table for all namespaces, using net_hash_mix(net) as additional
hash seed so entries are spread evenly even if addresses overlap.

We then also remove the per-namespace kmem cache and allocate all
conntrack entries from the same cache.

This is the last table: earlier patches already converted conntrack and
expectation tables.

I have another patch queued to convert nat bysource table to an rhashtable.
However; it seems better to wait until the next merge window so that bug
reports can be more easily pointed to the de-duplication work or a rhashtable
conversion, I will therefore hold this back for now.

Other items that might be de-namespaced but are not being worked on at
the moment:

struct ct_pcpu __percpu *pcpu_lists

Only problem might be reliable event redelivery; such conntracks sit on
the dying list, if this list is global we also need to make sure that we
don't spend too much cycles iterating, especially if lots of namespaces
use reliable event delivery and are backlogged (userspace not reading
events fast enough).

struct ip_conntrack_stat __percpu *stat;

Easy to convert. However this would mean that information gets leaked
as all namespaces would see same stats.


             reply	other threads:[~2016-05-09 14:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-09 14:24 Florian Westphal [this message]
2016-05-09 14:24 ` [PATCH nf-next 1/3] netfilter: conntrack: make netns address part of nat bysrc hash Florian Westphal
2016-05-09 14:24 ` [PATCH nf-next 2/3] netfilter: conntrack: use a single nat bysource table for all namespaces Florian Westphal
2016-05-09 14:24 ` [PATCH nf-next 3/3] netfilter: conntrack: use single slab cache Florian Westphal
2016-05-09 14:45 ` [PATCH nf-next 0/3] netfilter: remove per-netns conntrack tables, part 3 Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462803872-13497-1-git-send-email-fw@strlen.de \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).