From: tcharding <me@tobin.cc>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Tobin C Harding <me@tobin.cc>,
Pablo Neira Ayuso <pablo@netfilter.org>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org
Subject: [PATCH 3/3] bridge: netfilter: checkpatch null comparison fixes
Date: Tue, 10 May 2016 11:26:58 +1000 [thread overview]
Message-ID: <1462843618-21914-4-git-send-email-me@tobin.cc> (raw)
In-Reply-To: <1462843618-21914-1-git-send-email-me@tobin.cc>
From: Tobin C Harding <me@tobin.cc>
checkpatch produces comparison to null 'checks'.
This patch amends them.
Signed-off-by: Tobin C Harding <me@tobin.cc>
---
net/bridge/netfilter/ebt_stp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bridge/netfilter/ebt_stp.c b/net/bridge/netfilter/ebt_stp.c
index 9df943f..677904f 100644
--- a/net/bridge/netfilter/ebt_stp.c
+++ b/net/bridge/netfilter/ebt_stp.c
@@ -128,7 +128,7 @@ ebt_stp_mt(const struct sk_buff *skb, struct xt_action_param *par)
const u8 header[6] = {0x42, 0x42, 0x03, 0x00, 0x00, 0x00};
sp = skb_header_pointer(skb, 0, sizeof(_stph), &_stph);
- if (sp == NULL)
+ if (!sp)
return false;
/* The stp code only considers these */
@@ -146,7 +146,7 @@ ebt_stp_mt(const struct sk_buff *skb, struct xt_action_param *par)
st = skb_header_pointer(skb, sizeof(_stph),
sizeof(_stpc), &_stpc);
- if (st == NULL)
+ if (!st)
return false;
return ebt_filter_config(info, st);
}
--
2.8.2
next prev parent reply other threads:[~2016-05-10 1:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 1:26 [PATCH 0/3] bridge: netfilter: checkpatch fixes tcharding
2016-05-10 1:26 ` [PATCH 1/3] bridge: netfilter: checkpatch whitespace fixes tcharding
2016-06-07 15:14 ` Pablo Neira Ayuso
2016-06-07 17:04 ` Joe Perches
2016-06-07 17:34 ` Pablo Neira Ayuso
2016-06-07 18:02 ` Joe Perches
2016-06-08 11:52 ` Pablo Neira Ayuso
2016-06-08 16:52 ` Joe Perches
2016-06-08 17:31 ` Pablo Neira Ayuso
2016-06-08 17:38 ` Pablo Neira Ayuso
2016-06-09 18:00 ` Joe Perches
2016-06-11 10:44 ` Tobin Harding
2016-05-10 1:26 ` [PATCH 2/3] bridge: netfilter: checkpatch data type fixes tcharding
2016-06-07 15:19 ` Pablo Neira Ayuso
2016-05-10 1:26 ` tcharding [this message]
2016-06-07 15:21 ` [PATCH 3/3] bridge: netfilter: checkpatch null comparison fixes Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462843618-21914-4-git-send-email-me@tobin.cc \
--to=me@tobin.cc \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).