From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH nft 1/2] parser_bison: update flow table syntax
Date: Fri, 13 May 2016 20:08:28 +0200 [thread overview]
Message-ID: <1463162909-23139-1-git-send-email-pablo@netfilter.org> (raw)
Before we release next nft version, update the syntax to wrap the flow
table definition between brackets, eg.
# nft add rule filter input tcp dport 22 ct state new \
flow table ssh { ip saddr limit rate 10/second }
# nft add rule filter input \
flow table acct { iif . ip saddr timeout 60s counter }
When playing around with this in your initial patchset I found very
confusing that it may not look obvious to users that they can only use
one single statement.
For example:
# nft add rule filter input \
flow table acct iif . ip saddr timeout 60s counter limit rate 10/second
~~~~~~~~~~~~~~~~~~~~
Note that this limit rate applies globally, so this patch resolves this
ambiguity.
This may cause us problems in the future too if we extend this to
support more than one single statement per flowtable entry (Not
telling we need this now, but if someone comes up with a useful
usecase, we should be capable of extending this).
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/parser_bison.y | 12 ++++++------
src/statement.c | 2 ++
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/parser_bison.y b/src/parser_bison.y
index 8a7785b..76cf65c 100644
--- a/src/parser_bison.y
+++ b/src/parser_bison.y
@@ -1765,17 +1765,17 @@ set_stmt_op : ADD { $$ = NFT_DYNSET_OP_ADD; }
| UPDATE { $$ = NFT_DYNSET_OP_UPDATE; }
;
-flow_stmt : flow_stmt_alloc flow_stmt_opts flow_key_expr stmt
+flow_stmt : flow_stmt_alloc flow_stmt_opts '{' flow_key_expr stmt '}'
{
- $1->flow.key = $3;
- $1->flow.stmt = $4;
+ $1->flow.key = $4;
+ $1->flow.stmt = $5;
$$->location = @$;
$$ = $1;
}
- | flow_stmt_alloc flow_key_expr stmt
+ | flow_stmt_alloc '{' flow_key_expr stmt '}'
{
- $1->flow.key = $2;
- $1->flow.stmt = $3;
+ $1->flow.key = $3;
+ $1->flow.stmt = $4;
$$->location = @$;
$$ = $1;
}
diff --git a/src/statement.c b/src/statement.c
index 988cfeb..76f528b 100644
--- a/src/statement.c
+++ b/src/statement.c
@@ -112,9 +112,11 @@ static void flow_stmt_print(const struct stmt *stmt)
expr_print(stmt->flow.set);
printf(" ");
}
+ printf("{ ");
expr_print(stmt->flow.key);
printf(" ");
stmt_print(stmt->flow.stmt);
+ printf("} ");
}
static void flow_stmt_destroy(struct stmt *stmt)
--
2.1.4
next reply other threads:[~2016-05-13 18:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 18:08 Pablo Neira Ayuso [this message]
2016-05-13 18:08 ` [PATCH nft 2/2] include: constify nlexpr field in location structure Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463162909-23139-1-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).