From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH nft] netlink_delinerize: don't use meta_match_postprocess for ct pp
Date: Tue, 24 May 2016 14:02:49 +0200 [thread overview]
Message-ID: <1464091369-4230-1-git-send-email-fw@strlen.de> (raw)
meta_match_postprocess uses meta.base which is only accessible if
left expression has EXPR_META type, so we can't use it to handle ct postprocessing.
To reduce copy-pastry factor the common part into ct_meta_common_postprocess(),
then call that from both meta and ct postprocessing.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
src/netlink_delinearize.c | 36 +++++++++++++++++++++++++++++-------
1 file changed, 29 insertions(+), 7 deletions(-)
diff --git a/src/netlink_delinearize.c b/src/netlink_delinearize.c
index de5d66c..9e26078 100644
--- a/src/netlink_delinearize.c
+++ b/src/netlink_delinearize.c
@@ -1161,6 +1161,23 @@ static void payload_match_postprocess(struct rule_pp_ctx *ctx,
}
}
+static void ct_meta_common_postprocess(const struct expr *expr)
+{
+ const struct expr *left = expr->left;
+ struct expr *right = expr->right;
+
+ switch (expr->op) {
+ case OP_LOOKUP:
+ expr_set_type(right, left->dtype, left->byteorder);
+ if (right->dtype == &integer_type)
+ integer_type_postprocess(right);
+ break;
+
+ default:
+ break;
+ }
+}
+
static void meta_match_postprocess(struct rule_pp_ctx *ctx,
const struct expr *expr)
{
@@ -1178,13 +1195,8 @@ static void meta_match_postprocess(struct rule_pp_ctx *ctx,
payload_dependency_store(&ctx->pdctx, ctx->stmt,
left->meta.base);
break;
- case OP_LOOKUP:
- expr_set_type(expr->right, expr->left->dtype,
- expr->left->byteorder);
- if (expr->right->dtype == &integer_type)
- integer_type_postprocess(expr->right);
- break;
default:
+ ct_meta_common_postprocess(expr);
break;
}
}
@@ -1192,7 +1204,17 @@ static void meta_match_postprocess(struct rule_pp_ctx *ctx,
static void ct_match_postprocess(struct rule_pp_ctx *ctx,
const struct expr *expr)
{
- return meta_match_postprocess(ctx, expr);
+ switch (expr->op) {
+ case OP_EQ:
+ if (expr->right->ops->type == EXPR_RANGE)
+ break;
+
+ expr->left->ops->pctx_update(&ctx->pctx, expr);
+ break;
+ default:
+ ct_meta_common_postprocess(expr);
+ break;
+ }
}
/* Convert a bitmask to a prefix length */
--
2.7.3
next reply other threads:[~2016-05-24 12:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 12:02 Florian Westphal [this message]
2016-05-25 8:36 ` [PATCH nft] netlink_delinerize: don't use meta_match_postprocess for ct pp Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464091369-4230-1-git-send-email-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).