From: "Anders K. Pedersen" <akp@akp.dk>
To: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Cc: fw@strlen.de
Subject: Re: [PATCH nf] netfilter: nft_rbtree: ignore inactive matching element with no descendants
Date: Mon, 01 Aug 2016 16:27:38 +0200 [thread overview]
Message-ID: <1470061658.1097.5.camel@akp.dk> (raw)
In-Reply-To: <1470051523-12223-1-git-send-email-pablo@netfilter.org>
On man, 2016-08-01 at 13:38 +0200, Pablo Neira Ayuso wrote:
> If we find a matching element that is inactive with no descendants,
> we
> jump to the found label, then crash because of nul-dereference on the
> left branch.
>
> Fix this by checking that the element is active and not an interval
> end
> and skipping the logic that only applies to the tree iteration.
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
I applied this on top of Linux 4.7 and verified that it solves the
kernel BUGs, I previously ran into with nftables sets.
Tested-by: Anders K. Pedersen <akp@akp.dk>
Thanks,
Anders K. Pedersen
prev parent reply other threads:[~2016-08-01 14:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 11:38 [PATCH nf] netfilter: nft_rbtree: ignore inactive matching element with no descendants Pablo Neira Ayuso
2016-08-01 14:27 ` Anders K. Pedersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470061658.1097.5.camel@akp.dk \
--to=akp@akp.dk \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).