From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: arturo.borrero.glez@gmail.com
Subject: [PATCH nft 1/3] scanner: honor absolute and relative paths via include file
Date: Tue, 9 Aug 2016 11:29:40 +0200 [thread overview]
Message-ID: <1470734982-10298-1-git-send-email-pablo@netfilter.org> (raw)
If the path refers to an absolute or relative path, do not check for the
default include paths, eg. /etc/nftables/.
Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1040
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/scanner.l | 24 +++++++++++++++++-------
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/src/scanner.l b/src/scanner.l
index 88669d0..6f1a551 100644
--- a/src/scanner.l
+++ b/src/scanner.l
@@ -611,6 +611,13 @@ err:
return -1;
}
+static bool search_in_include_path(const char *filename)
+{
+ return (strncmp(filename, "./", strlen("./") != 0) &&
+ strncmp(filename, "../", strlen("../") != 0) &&
+ filename[0] != '/');
+}
+
int scanner_include_file(void *scanner, const char *filename,
const struct location *loc)
{
@@ -622,13 +629,16 @@ int scanner_include_file(void *scanner, const char *filename,
FILE *f;
f = NULL;
- for (i = 0; i < INCLUDE_PATHS_MAX; i++) {
- if (include_paths[i] == NULL)
- break;
- snprintf(buf, sizeof(buf), "%s/%s", include_paths[i], filename);
- f = fopen(buf, "r");
- if (f != NULL)
- break;
+ if (search_in_include_path(filename)) {
+ for (i = 0; i < INCLUDE_PATHS_MAX; i++) {
+ if (include_paths[i] == NULL)
+ break;
+ snprintf(buf, sizeof(buf), "%s/%s",
+ include_paths[i], filename);
+ f = fopen(buf, "r");
+ if (f != NULL)
+ break;
+ }
}
if (f == NULL) {
f = fopen(filename, "r");
--
2.1.4
next reply other threads:[~2016-08-09 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 9:29 Pablo Neira Ayuso [this message]
2016-08-09 9:29 ` [PATCH nft 2/3] scanner: don't fall back on current directory if include is not found Pablo Neira Ayuso
2016-08-09 9:29 ` [PATCH nft 3/3] scanner: don't break line on include error message Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470734982-10298-1-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).