netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH v3 nf-next 6/7] netfilter: conntrack: resched gc again if eviction rate is high
Date: Thu, 25 Aug 2016 15:33:34 +0200	[thread overview]
Message-ID: <1472132015-10264-7-git-send-email-fw@strlen.de> (raw)
In-Reply-To: <1472132015-10264-1-git-send-email-fw@strlen.de>

If we evicted a large fraction of the scanned conntrack entries re-schedule
the next gc cycle for immediate execution.

This triggers during tests where load is high, then drops to zero and
many connections will be in TW/CLOSE state with < 30 second timeouts.

Without this change it will take several minutes until conntrack count
comes back to normal.

Signed-off-by: Florian Westphal <fw@strlen.de>
---
 net/netfilter/nf_conntrack_core.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
index f95a9e9..7c66ce40 100644
--- a/net/netfilter/nf_conntrack_core.c
+++ b/net/netfilter/nf_conntrack_core.c
@@ -945,6 +945,7 @@ static void gc_worker(struct work_struct *work)
 {
 	unsigned int i, goal, buckets = 0, expired_count = 0;
 	unsigned long next_run = GC_INTERVAL;
+	unsigned int ratio, scanned = 0;
 	struct conntrack_gc_work *gc_work;
 
 	gc_work = container_of(work, struct conntrack_gc_work, dwork.work);
@@ -969,6 +970,7 @@ static void gc_worker(struct work_struct *work)
 		hlist_nulls_for_each_entry_rcu(h, n, &ct_hash[i], hnnode) {
 			tmp = nf_ct_tuplehash_to_ctrack(h);
 
+			scanned++;
 			if (nf_ct_is_expired(tmp)) {
 				nf_ct_gc_expired(tmp);
 				expired_count++;
@@ -988,6 +990,10 @@ static void gc_worker(struct work_struct *work)
 	if (gc_work->exiting)
 		return;
 
+	ratio = scanned ? expired_count * 100 / scanned : 0;
+	if (ratio >= 90)
+		next_run = 0;
+
 	gc_work->last_bucket = i;
 	schedule_delayed_work(&gc_work->dwork, next_run);
 }
-- 
2.7.3


  parent reply	other threads:[~2016-08-25 13:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25 13:33 netfilter: get rid of per-object conntrack timers Florian Westphal
2016-08-25 13:33 ` [PATCH v3 nf-next 1/7] netfilter: restart search if moved to other chain Florian Westphal
2016-08-25 13:33 ` [PATCH v3 nf-next 2/7] netfilter: don't rely on DYING bit to detect when destroy event was sent Florian Westphal
2016-08-25 13:33 ` [PATCH v3 nf-next 3/7] netfilter: conntrack: get rid of conntrack timer Florian Westphal
2016-08-25 13:33 ` [PATCH v3 nf-next 4/7] netfilter: evict stale entries on netlink dumps Florian Westphal
2016-08-25 13:33 ` [PATCH v3 nf-next 5/7] netfilter: conntrack: add gc worker to remove timed-out entries Florian Westphal
2016-08-25 16:06   ` Eric Dumazet
2016-08-25 13:33 ` Florian Westphal [this message]
2016-08-25 16:07   ` [PATCH v3 nf-next 6/7] netfilter: conntrack: resched gc again if eviction rate is high Eric Dumazet
2016-08-25 13:33 ` [PATCH v3 nf-next 7/7] netfilter: remove __nf_ct_kill_acct helper Florian Westphal
2016-08-30  9:43 ` netfilter: get rid of per-object conntrack timers Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472132015-10264-7-git-send-email-fw@strlen.de \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).