From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH libnftnl 1/3] expr: numgen: use switch to handle numgen types from snprintf
Date: Tue, 30 Aug 2016 12:41:07 +0200 [thread overview]
Message-ID: <1472553669-1910-1-git-send-email-pablo@netfilter.org> (raw)
Use switch instead of if branch.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/expr/numgen.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/expr/numgen.c b/src/expr/numgen.c
index 0981d72..7be8270 100644
--- a/src/expr/numgen.c
+++ b/src/expr/numgen.c
@@ -189,16 +189,17 @@ nftnl_expr_ng_snprintf_default(char *buf, size_t size,
struct nftnl_expr_ng *ng = nftnl_expr_data(e);
int len = size, offset = 0, ret;
- if (ng->type == NFT_NG_INCREMENTAL) {
+ switch (ng->type) {
+ case NFT_NG_INCREMENTAL:
ret = snprintf(buf, len, "reg %u = inc(%u)", ng->dreg,
ng->until);
SNPRINTF_BUFFER_SIZE(ret, size, len, offset);
- }
-
- if (ng->type == NFT_NG_RANDOM) {
+ break;
+ case NFT_NG_RANDOM:
ret = snprintf(buf, len, "reg %u = random(%u)", ng->dreg,
ng->until);
SNPRINTF_BUFFER_SIZE(ret, size, len, offset);
+ break;
}
return offset;
--
2.1.4
next reply other threads:[~2016-08-30 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 10:41 Pablo Neira Ayuso [this message]
2016-08-30 10:41 ` [PATCH libnftnl 2/3] expr: numgen: add missing trailing whitespace Pablo Neira Ayuso
2016-08-30 10:41 ` [PATCH libnftnl 3/3] expr: hash: missing trailing space and modulus in hexadecimal in snprintf Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472553669-1910-1-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).