netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH conntrackd 1/2] conntrackd: Remove obsolete rule to catch ambiguous Checksum option
Date: Fri, 10 Mar 2017 10:41:47 +0100	[thread overview]
Message-ID: <1489138908-3822-1-git-send-email-pablo@netfilter.org> (raw)

This warning has been there for long time, and the example files we
provide already come with the right syntax, so remove this old chunk.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 src/read_config_yy.y | 23 -----------------------
 1 file changed, 23 deletions(-)

diff --git a/src/read_config_yy.y b/src/read_config_yy.y
index 97f905d13091..2c08d4e5b1b3 100644
--- a/src/read_config_yy.y
+++ b/src/read_config_yy.y
@@ -185,28 +185,6 @@ purge: T_PURGE T_NUMBER
 	conf.purge_timeout = $2;
 };
 
-checksum: T_CHECKSUM T_ON 
-{
-	dlog(LOG_WARNING, "the use of `Checksum' outside the "
-	     "`Multicast' clause is ambiguous");
-	/* 
-	 * XXX: The use of Checksum outside of the Multicast clause is broken
-	 *	if we have more than one dedicated links.
-	 */
-	conf.channel[0].u.mcast.checksum = 0;
-};
-
-checksum: T_CHECKSUM T_OFF
-{
-	dlog(LOG_WARNING, "the use of `Checksum' outside the "
-	     "`Multicast' clause is ambiguous");
-	/*
-	 * XXX: The use of Checksum outside of the Multicast clause is broken
-	 *	if we have more than one dedicated links.
-	 */
-	conf.channel[0].u.mcast.checksum = 1;
-};
-
 multicast_line : T_MULTICAST '{' multicast_options '}'
 {
 	if (conf.channel_type_global != CHANNEL_NONE &&
@@ -693,7 +671,6 @@ sync_line: refreshtime
 	 | expiretime
 	 | timeout
 	 | purge
-	 | checksum
 	 | multicast_line
 	 | udp_line
 	 | tcp_line
-- 
2.1.4


             reply	other threads:[~2017-03-10  9:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10  9:41 Pablo Neira Ayuso [this message]
2017-03-10  9:41 ` [PATCH conntrackd 2/2] conntrackd: CommitTimeout breaks DisableExternalCache set On Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489138908-3822-1-git-send-email-pablo@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).