From: Eric Leblond <eric@regit.org>
To: Kaarle Ritvanen <kaarle.ritvanen@datakunkku.fi>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH ulogd2 1/2] ulogd.conf: harmonize log file options with module default values
Date: Tue, 16 May 2017 00:05:21 +0200 [thread overview]
Message-ID: <1494885921.15338.6.camel@regit.org> (raw)
In-Reply-To: <alpine.LFD.2.20.1703272133320.10745@kanala.kunkku.net>
Hello,
On Wed, 2017-04-12 at 14:40 +0300, Kaarle Ritvanen wrote:
> On Tue, 7 Mar 2017, Eric Leblond wrote:
>
> > I really like the idea of getting an harmonized naming for the log
> > files but I think we should do it reverse for values that are not
> > commented in the configuration file. Most distributions and install
> > are
> > shipping with a copy of default configuration.
> >
> > Most users won't have changed the values that are uncommented. So
> > they
> > will have on disk the log file with name defined in the
> > configuration
> > file. And they will benefit from a new logrotate file. Thus we
> > should
> > use the file name defined in the conf as value of the default file
> > name
> > in code.
> >
> > Could you resubmit a patchset ?
>
> I preprared a new patch set according to your feedback:
>
> http://marc.info/?l=netfilter-devel&m=149064027208491&w=2
> http://marc.info/?l=netfilter-devel&m=149064028308496&w=2
>
> Please take a look at them.
No excuse on me to have missed that. Really sorry. I've just pushed
that to git.
Best regards,
--
Eric Leblond <eric@regit.org>
prev parent reply other threads:[~2017-05-15 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 9:47 [PATCH ulogd2 1/2] ulogd.conf: harmonize log file options with module default values Kaarle Ritvanen
2017-02-13 9:47 ` [PATCH ulogd2 2/2] rotate all default output files Kaarle Ritvanen
2017-03-07 14:00 ` [PATCH ulogd2 1/2] ulogd.conf: harmonize log file options with module default values Eric Leblond
2017-04-12 11:40 ` Kaarle Ritvanen
2017-05-15 22:05 ` Eric Leblond [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494885921.15338.6.camel@regit.org \
--to=eric@regit.org \
--cc=kaarle.ritvanen@datakunkku.fi \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).