From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH nft] evaluate: Better error reporting for bad set references
Date: Mon, 19 Jun 2017 14:04:49 +0200 [thread overview]
Message-ID: <1497873889-4548-1-git-send-email-pablo@netfilter.org> (raw)
In case you refer to an unexisting set, bail out with:
# nft -f rc.nftables-test
rc.nftables-test:64:34-49: Error: Set 'reject_to_rule2' does not exist
ip protocol vmap @reject_to_rule2
^^^^^^^^^^^^^^^^
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/evaluate.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/evaluate.c b/src/evaluate.c
index ec898033c984..ca8b63b74fdc 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -192,8 +192,9 @@ static int expr_evaluate_symbol(struct eval_ctx *ctx, struct expr **expr)
set = set_lookup(table, (*expr)->identifier);
if (set == NULL)
- return cmd_error(ctx, "Could not process rule: Set '%s' does not exist",
- (*expr)->identifier);
+ return expr_error(ctx->msgs, *expr,
+ "Set '%s' does not exist",
+ (*expr)->identifier);
new = set_ref_expr_alloc(&(*expr)->location, set);
break;
}
--
2.1.4
reply other threads:[~2017-06-19 12:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497873889-4548-1-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).