netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH nft] evaluate: Better error reporting for bad set references
@ 2017-06-19 12:04 Pablo Neira Ayuso
  0 siblings, 0 replies; only message in thread
From: Pablo Neira Ayuso @ 2017-06-19 12:04 UTC (permalink / raw)
  To: netfilter-devel

In case you refer to an unexisting set, bail out with:

 # nft -f rc.nftables-test
 rc.nftables-test:64:34-49: Error: Set 'reject_to_rule2' does not exist
                ip protocol vmap @reject_to_rule2
                                 ^^^^^^^^^^^^^^^^

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 src/evaluate.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/evaluate.c b/src/evaluate.c
index ec898033c984..ca8b63b74fdc 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -192,8 +192,9 @@ static int expr_evaluate_symbol(struct eval_ctx *ctx, struct expr **expr)
 
 		set = set_lookup(table, (*expr)->identifier);
 		if (set == NULL)
-			return cmd_error(ctx, "Could not process rule: Set '%s' does not exist",
-					 (*expr)->identifier);
+			return expr_error(ctx->msgs, *expr,
+					  "Set '%s' does not exist",
+					  (*expr)->identifier);
 		new = set_ref_expr_alloc(&(*expr)->location, set);
 		break;
 	}
-- 
2.1.4


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-06-19 12:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-19 12:04 [PATCH nft] evaluate: Better error reporting for bad set references Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).