* [PATCH nf-next] netfilter: conntrack: Change to deferable work queue
@ 2017-07-21 1:42 Subash Abhinov Kasiviswanathan
2017-07-31 17:05 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Subash Abhinov Kasiviswanathan @ 2017-07-21 1:42 UTC (permalink / raw)
To: netfilter-devel, pablo, fw; +Cc: Subash Abhinov Kasiviswanathan
Delayed workqueue causes wakeups to idle CPUs. This was
causing a power impact for devices. Use deferable work
queue instead so that gc_worker runs when CPU is active only.
Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
---
net/netfilter/nf_conntrack_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c
index 9979f46..2a51ef9 100644
--- a/net/netfilter/nf_conntrack_core.c
+++ b/net/netfilter/nf_conntrack_core.c
@@ -1084,7 +1084,7 @@ static void gc_worker(struct work_struct *work)
static void conntrack_gc_work_init(struct conntrack_gc_work *gc_work)
{
- INIT_DELAYED_WORK(&gc_work->dwork, gc_worker);
+ INIT_DEFERRABLE_WORK(&gc_work->dwork, gc_worker);
gc_work->next_gc_run = HZ;
gc_work->exiting = false;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH nf-next] netfilter: conntrack: Change to deferable work queue
2017-07-21 1:42 [PATCH nf-next] netfilter: conntrack: Change to deferable work queue Subash Abhinov Kasiviswanathan
@ 2017-07-31 17:05 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2017-07-31 17:05 UTC (permalink / raw)
To: Subash Abhinov Kasiviswanathan; +Cc: netfilter-devel, fw
On Thu, Jul 20, 2017 at 07:42:19PM -0600, Subash Abhinov Kasiviswanathan wrote:
> Delayed workqueue causes wakeups to idle CPUs. This was
> causing a power impact for devices. Use deferable work
> queue instead so that gc_worker runs when CPU is active only.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-31 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-21 1:42 [PATCH nf-next] netfilter: conntrack: Change to deferable work queue Subash Abhinov Kasiviswanathan
2017-07-31 17:05 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).